Skip to content

Commit 76cffcc

Browse files
yangerkunaxboe
authored andcommitted
block-mq: fix comments in blk_mq_queue_tag_busy_iter
'f5bbbbe4d635 ("blk-mq: sync the update nr_hw_queues with blk_mq_queue_tag_busy_iter")' introduce a bug what we may sleep between rcu lock. Then '530ca2c9bd69 ("blk-mq: Allow blocking queue tag iter callbacks")' fix it by get request_queue's ref. And 'a9a808084d6a ("block: Remove the synchronize_rcu() call from __blk_mq_update_nr_hw_queues()")' remove the synchronize_rcu in __blk_mq_update_nr_hw_queues. We need update the confused comments in blk_mq_queue_tag_busy_iter. Signed-off-by: yangerkun <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 8229cca commit 76cffcc

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

block/blk-mq-tag.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,9 +416,7 @@ void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_iter_fn *fn,
416416
/*
417417
* __blk_mq_update_nr_hw_queues() updates nr_hw_queues and queue_hw_ctx
418418
* while the queue is frozen. So we can use q_usage_counter to avoid
419-
* racing with it. __blk_mq_update_nr_hw_queues() uses
420-
* synchronize_rcu() to ensure this function left the critical section
421-
* below.
419+
* racing with it.
422420
*/
423421
if (!percpu_ref_tryget(&q->q_usage_counter))
424422
return;

0 commit comments

Comments
 (0)