Skip to content

Commit 7718453

Browse files
fancergregkh
authored andcommitted
serial: 8250: Discard RTS/DTS setting from clock update method
It has been a mistake to add the MCR register RTS/DTS fields setting in the generic method of the UART reference clock update. There is no point in asserting these lines at that procedure. Just discard the serial8250_out_MCR() mathod invocation from there then. Fixes: 868f3ee ("serial: 8250: Add 8250 port clock update method") Tested-by: Hans de Goede <[email protected]> Signed-off-by: Serge Semin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent edd64f3 commit 7718453

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/tty/serial/8250/8250_port.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2665,7 +2665,6 @@ void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk)
26652665

26662666
serial8250_set_divisor(port, baud, quot, frac);
26672667
serial_port_out(port, UART_LCR, up->lcr);
2668-
serial8250_out_MCR(up, UART_MCR_DTR | UART_MCR_RTS);
26692668

26702669
spin_unlock_irqrestore(&port->lock, flags);
26712670
serial8250_rpm_put(up);

0 commit comments

Comments
 (0)