Skip to content

Commit 7f7b96a

Browse files
achrisansravnborg
achrisan
authored and
sravnborg
committed
drm/kmb: Add support for KeemBay Display
This is a basic KMS atomic modesetting display driver for KeemBay family of SOCs. Driver has no 2D or 3D graphics. It calls into the ADV bridge driver at the connector level. Single CRTC with LCD controller->mipi DSI->ADV bridge Only 1080p resolution and single plane is supported at this time. v2: moved extern to .h, removed license text use drm_dev_init, upclassed dev_private, removed HAVE_IRQ.(Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb moved clocks under kmb_clock, consolidated clk initializations use drmm functions use DRM_GEM_CMA_DRIVER_OPS_VMAP v5: corrected spellings v6: corrected checkpatch warnings v7: review changes Sam Ravnborg and Thomas Zimmerman removed kmb_crtc.h kmb_crtc_cleanup (Thomas) renamed mode_set, kmb_load, inlined unload (Thomas) moved remaining logging to drm_*(Thomas) re-orged driver initialization (Thomas) moved plane_status to drm_private (Sam) removed unnecessary logs and defines and ifdef codes (Sam) call helper_check in plane_atomic_check (Sam) renamed set to get for bpp and format functions(Sam) use drm helper functions for reset, duplicate/destroy state instead of kmb functions (Sam) removed kmb_priv from kmb_plane and removed kmb_plane_state (Sam) v8: get clk_pll0 from display node in dt v9: moved csc_coef_lcd to plane.c (Daniel Vetter) call drm_atomic_helper_shutdown in remove (Daniel V) use drm_crtc_handle_vblank (Daniel V) renamed kmb_dsi_hw_init to kmb_dsi_mode_set (Daniel V) complimentary changes to device tree changes (Rob) v10: call drm_crtc_arm_vblank_event in atomic_flush (Daniel V) moved global vars to kmb_private and added locks (Daniel V) changes in driver to accommodate changes in DT to separate DSI entries (Sam R) review changes to separate mipi DSI (Sam R) v11: review changes to separate msscam (Neil A,Sam R) v12: fixed warnings Reported-by: kernel test robot <[email protected]> Signed-off-by: Anitha Chrisanthus <[email protected]> Reviewed-by: Sam Ravnborg <[email protected]> Cc: Sam Ravnborg <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: Daniel Vetter <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 1bb8b7f commit 7f7b96a

File tree

5 files changed

+1493
-0
lines changed

5 files changed

+1493
-0
lines changed

‎drivers/gpu/drm/kmb/kmb_crtc.c

Lines changed: 214 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,214 @@
1+
// SPDX-License-Identifier: GPL-2.0-only
2+
/*
3+
* Copyright © 2018-2020 Intel Corporation
4+
*/
5+
6+
#include <linux/clk.h>
7+
8+
#include <drm/drm_atomic.h>
9+
#include <drm/drm_atomic_helper.h>
10+
#include <drm/drm_crtc.h>
11+
#include <drm/drm_crtc_helper.h>
12+
#include <drm/drm_print.h>
13+
#include <drm/drm_vblank.h>
14+
#include <drm/drm_modeset_helper_vtables.h>
15+
16+
#include "kmb_drv.h"
17+
#include "kmb_dsi.h"
18+
#include "kmb_plane.h"
19+
#include "kmb_regs.h"
20+
21+
struct kmb_crtc_timing {
22+
u32 vfront_porch;
23+
u32 vback_porch;
24+
u32 vsync_len;
25+
u32 hfront_porch;
26+
u32 hback_porch;
27+
u32 hsync_len;
28+
};
29+
30+
static int kmb_crtc_enable_vblank(struct drm_crtc *crtc)
31+
{
32+
struct drm_device *dev = crtc->dev;
33+
struct kmb_drm_private *kmb = to_kmb(dev);
34+
35+
/* Clear interrupt */
36+
kmb_write_lcd(kmb, LCD_INT_CLEAR, LCD_INT_VERT_COMP);
37+
/* Set which interval to generate vertical interrupt */
38+
kmb_write_lcd(kmb, LCD_VSTATUS_COMPARE,
39+
LCD_VSTATUS_COMPARE_VSYNC);
40+
/* Enable vertical interrupt */
41+
kmb_set_bitmask_lcd(kmb, LCD_INT_ENABLE,
42+
LCD_INT_VERT_COMP);
43+
return 0;
44+
}
45+
46+
static void kmb_crtc_disable_vblank(struct drm_crtc *crtc)
47+
{
48+
struct drm_device *dev = crtc->dev;
49+
struct kmb_drm_private *kmb = to_kmb(dev);
50+
51+
/* Clear interrupt */
52+
kmb_write_lcd(kmb, LCD_INT_CLEAR, LCD_INT_VERT_COMP);
53+
/* Disable vertical interrupt */
54+
kmb_clr_bitmask_lcd(kmb, LCD_INT_ENABLE,
55+
LCD_INT_VERT_COMP);
56+
}
57+
58+
static const struct drm_crtc_funcs kmb_crtc_funcs = {
59+
.destroy = drm_crtc_cleanup,
60+
.set_config = drm_atomic_helper_set_config,
61+
.page_flip = drm_atomic_helper_page_flip,
62+
.reset = drm_atomic_helper_crtc_reset,
63+
.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
64+
.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
65+
.enable_vblank = kmb_crtc_enable_vblank,
66+
.disable_vblank = kmb_crtc_disable_vblank,
67+
};
68+
69+
static void kmb_crtc_set_mode(struct drm_crtc *crtc)
70+
{
71+
struct drm_device *dev = crtc->dev;
72+
struct drm_display_mode *m = &crtc->state->adjusted_mode;
73+
struct kmb_crtc_timing vm;
74+
struct kmb_drm_private *kmb = to_kmb(dev);
75+
unsigned int val = 0;
76+
77+
/* Initialize mipi */
78+
kmb_dsi_mode_set(kmb->kmb_dsi, m, kmb->sys_clk_mhz);
79+
drm_info(dev,
80+
"vfp= %d vbp= %d vsyc_len=%d hfp=%d hbp=%d hsync_len=%d\n",
81+
m->crtc_vsync_start - m->crtc_vdisplay,
82+
m->crtc_vtotal - m->crtc_vsync_end,
83+
m->crtc_vsync_end - m->crtc_vsync_start,
84+
m->crtc_hsync_start - m->crtc_hdisplay,
85+
m->crtc_htotal - m->crtc_hsync_end,
86+
m->crtc_hsync_end - m->crtc_hsync_start);
87+
val = kmb_read_lcd(kmb, LCD_INT_ENABLE);
88+
kmb_clr_bitmask_lcd(kmb, LCD_INT_ENABLE, val);
89+
kmb_set_bitmask_lcd(kmb, LCD_INT_CLEAR, ~0x0);
90+
vm.vfront_porch = 2;
91+
vm.vback_porch = 2;
92+
vm.vsync_len = 8;
93+
vm.hfront_porch = 0;
94+
vm.hback_porch = 0;
95+
vm.hsync_len = 28;
96+
97+
drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hysnc-l=%d",
98+
__func__, __LINE__,
99+
m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch,
100+
vm.vsync_len, m->crtc_hdisplay, vm.hback_porch,
101+
vm.hfront_porch, vm.hsync_len);
102+
kmb_write_lcd(kmb, LCD_V_ACTIVEHEIGHT,
103+
m->crtc_vdisplay - 1);
104+
kmb_write_lcd(kmb, LCD_V_BACKPORCH, vm.vback_porch);
105+
kmb_write_lcd(kmb, LCD_V_FRONTPORCH, vm.vfront_porch);
106+
kmb_write_lcd(kmb, LCD_VSYNC_WIDTH, vm.vsync_len - 1);
107+
kmb_write_lcd(kmb, LCD_H_ACTIVEWIDTH,
108+
m->crtc_hdisplay - 1);
109+
kmb_write_lcd(kmb, LCD_H_BACKPORCH, vm.hback_porch);
110+
kmb_write_lcd(kmb, LCD_H_FRONTPORCH, vm.hfront_porch);
111+
kmb_write_lcd(kmb, LCD_HSYNC_WIDTH, vm.hsync_len - 1);
112+
/* This is hardcoded as 0 in the Myriadx code */
113+
kmb_write_lcd(kmb, LCD_VSYNC_START, 0);
114+
kmb_write_lcd(kmb, LCD_VSYNC_END, 0);
115+
/* Back ground color */
116+
kmb_write_lcd(kmb, LCD_BG_COLOUR_LS, 0x4);
117+
if (m->flags == DRM_MODE_FLAG_INTERLACE) {
118+
kmb_write_lcd(kmb,
119+
LCD_VSYNC_WIDTH_EVEN, vm.vsync_len - 1);
120+
kmb_write_lcd(kmb,
121+
LCD_V_BACKPORCH_EVEN, vm.vback_porch);
122+
kmb_write_lcd(kmb,
123+
LCD_V_FRONTPORCH_EVEN, vm.vfront_porch);
124+
kmb_write_lcd(kmb, LCD_V_ACTIVEHEIGHT_EVEN,
125+
m->crtc_vdisplay - 1);
126+
/* This is hardcoded as 10 in the Myriadx code */
127+
kmb_write_lcd(kmb, LCD_VSYNC_START_EVEN, 10);
128+
kmb_write_lcd(kmb, LCD_VSYNC_END_EVEN, 10);
129+
}
130+
kmb_write_lcd(kmb, LCD_TIMING_GEN_TRIG, 1);
131+
kmb_set_bitmask_lcd(kmb, LCD_CONTROL, LCD_CTRL_ENABLE);
132+
kmb_set_bitmask_lcd(kmb, LCD_INT_ENABLE, val);
133+
}
134+
135+
static void kmb_crtc_atomic_enable(struct drm_crtc *crtc,
136+
struct drm_atomic_state *state)
137+
{
138+
struct kmb_drm_private *kmb = crtc_to_kmb_priv(crtc);
139+
140+
clk_prepare_enable(kmb->kmb_clk.clk_lcd);
141+
kmb_crtc_set_mode(crtc);
142+
drm_crtc_vblank_on(crtc);
143+
}
144+
145+
static void kmb_crtc_atomic_disable(struct drm_crtc *crtc,
146+
struct drm_atomic_state *state)
147+
{
148+
struct kmb_drm_private *kmb = crtc_to_kmb_priv(crtc);
149+
struct drm_crtc_state *old_state = drm_atomic_get_old_crtc_state(state, crtc);
150+
151+
/* due to hw limitations, planes need to be off when crtc is off */
152+
drm_atomic_helper_disable_planes_on_crtc(old_state, false);
153+
154+
drm_crtc_vblank_off(crtc);
155+
clk_disable_unprepare(kmb->kmb_clk.clk_lcd);
156+
}
157+
158+
static void kmb_crtc_atomic_begin(struct drm_crtc *crtc,
159+
struct drm_atomic_state *state)
160+
{
161+
struct drm_device *dev = crtc->dev;
162+
struct kmb_drm_private *kmb = to_kmb(dev);
163+
164+
kmb_clr_bitmask_lcd(kmb, LCD_INT_ENABLE,
165+
LCD_INT_VERT_COMP);
166+
}
167+
168+
static void kmb_crtc_atomic_flush(struct drm_crtc *crtc,
169+
struct drm_atomic_state *state)
170+
{
171+
struct drm_device *dev = crtc->dev;
172+
struct kmb_drm_private *kmb = to_kmb(dev);
173+
174+
kmb_set_bitmask_lcd(kmb, LCD_INT_ENABLE,
175+
LCD_INT_VERT_COMP);
176+
177+
spin_lock_irq(&crtc->dev->event_lock);
178+
if (crtc->state->event) {
179+
if (drm_crtc_vblank_get(crtc) == 0)
180+
drm_crtc_arm_vblank_event(crtc, crtc->state->event);
181+
else
182+
drm_crtc_send_vblank_event(crtc, crtc->state->event);
183+
}
184+
crtc->state->event = NULL;
185+
spin_unlock_irq(&crtc->dev->event_lock);
186+
}
187+
188+
static const struct drm_crtc_helper_funcs kmb_crtc_helper_funcs = {
189+
.atomic_begin = kmb_crtc_atomic_begin,
190+
.atomic_enable = kmb_crtc_atomic_enable,
191+
.atomic_disable = kmb_crtc_atomic_disable,
192+
.atomic_flush = kmb_crtc_atomic_flush,
193+
};
194+
195+
int kmb_setup_crtc(struct drm_device *drm)
196+
{
197+
struct kmb_drm_private *kmb = to_kmb(drm);
198+
struct kmb_plane *primary;
199+
int ret;
200+
201+
primary = kmb_plane_init(drm);
202+
if (IS_ERR(primary))
203+
return PTR_ERR(primary);
204+
205+
ret = drm_crtc_init_with_planes(drm, &kmb->crtc, &primary->base_plane,
206+
NULL, &kmb_crtc_funcs, NULL);
207+
if (ret) {
208+
kmb_plane_destroy(&primary->base_plane);
209+
return ret;
210+
}
211+
212+
drm_crtc_helper_add(&kmb->crtc, &kmb_crtc_helper_funcs);
213+
return 0;
214+
}

0 commit comments

Comments
 (0)