Skip to content

Commit 8072b39

Browse files
chleroyzx2c4
authored andcommitted
powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO64
Extend getrandom() vDSO implementation to VDSO64. Tested on QEMU on both ppc64_defconfig and ppc64le_defconfig. Results from a Power9 (PowerNV): ~ # ./vdso_test_getrandom bench-single    vdso: 25000000 times in 0.787943615 seconds    libc: 25000000 times in 14.101887252 seconds    syscall: 25000000 times in 14.047475082 seconds Signed-off-by: Christophe Leroy <[email protected]> Tested-by: Madhavan Srinivasan <[email protected]> Acked-by: Michael Ellerman <[email protected]> Signed-off-by: Jason A. Donenfeld <[email protected]>
1 parent 53cee50 commit 8072b39

File tree

5 files changed

+69
-3
lines changed

5 files changed

+69
-3
lines changed

arch/powerpc/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ config PPC
311311
select SYSCTL_EXCEPTION_TRACE
312312
select THREAD_INFO_IN_TASK
313313
select TRACE_IRQFLAGS_SUPPORT
314-
select VDSO_GETRANDOM if VDSO32
314+
select VDSO_GETRANDOM
315315
#
316316
# Please keep this list sorted alphabetically.
317317
#

arch/powerpc/kernel/vdso/Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ obj-vdso32 = sigtramp32-32.o gettimeofday-32.o datapage-32.o cacheflush-32.o not
99
obj-vdso64 = sigtramp64-64.o gettimeofday-64.o datapage-64.o cacheflush-64.o note-64.o getcpu-64.o
1010

1111
obj-vdso32 += getrandom-32.o vgetrandom-chacha-32.o
12+
obj-vdso64 += getrandom-64.o vgetrandom-chacha-64.o
1213

1314
ifneq ($(c-gettimeofday-y),)
1415
CFLAGS_vgettimeofday-32.o += -include $(c-gettimeofday-y)
@@ -21,6 +22,7 @@ endif
2122

2223
ifneq ($(c-getrandom-y),)
2324
CFLAGS_vgetrandom-32.o += -include $(c-getrandom-y)
25+
CFLAGS_vgetrandom-64.o += -include $(c-getrandom-y) $(call cc-option, -ffixed-r30)
2426
endif
2527

2628
# Build rules
@@ -34,7 +36,7 @@ endif
3436
targets := $(obj-vdso32) vdso32.so.dbg vgettimeofday-32.o vgetrandom-32.o
3537
targets += crtsavres-32.o
3638
obj-vdso32 := $(addprefix $(obj)/, $(obj-vdso32))
37-
targets += $(obj-vdso64) vdso64.so.dbg vgettimeofday-64.o
39+
targets += $(obj-vdso64) vdso64.so.dbg vgettimeofday-64.o vgetrandom-64.o
3840
obj-vdso64 := $(addprefix $(obj)/, $(obj-vdso64))
3941

4042
ccflags-y := -fno-common -fno-builtin -DBUILD_VDSO
@@ -71,7 +73,7 @@ CPPFLAGS_vdso64.lds += -P -C
7173
# link rule for the .so file, .lds has to be first
7274
$(obj)/vdso32.so.dbg: $(obj)/vdso32.lds $(obj-vdso32) $(obj)/vgettimeofday-32.o $(obj)/vgetrandom-32.o $(obj)/crtsavres-32.o FORCE
7375
$(call if_changed,vdso32ld_and_check)
74-
$(obj)/vdso64.so.dbg: $(obj)/vdso64.lds $(obj-vdso64) $(obj)/vgettimeofday-64.o FORCE
76+
$(obj)/vdso64.so.dbg: $(obj)/vdso64.lds $(obj-vdso64) $(obj)/vgettimeofday-64.o $(obj)/vgetrandom-64.o FORCE
7577
$(call if_changed,vdso64ld_and_check)
7678

7779
# assembly rules for the .S files
@@ -87,6 +89,8 @@ $(obj-vdso64): %-64.o: %.S FORCE
8789
$(call if_changed_dep,vdso64as)
8890
$(obj)/vgettimeofday-64.o: %-64.o: %.c FORCE
8991
$(call if_changed_dep,cc_o_c)
92+
$(obj)/vgetrandom-64.o: %-64.o: %.c FORCE
93+
$(call if_changed_dep,cc_o_c)
9094

9195
# Generate VDSO offsets using helper script
9296
gen-vdso32sym := $(src)/gen_vdso32_offsets.sh

arch/powerpc/kernel/vdso/getrandom.S

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,18 @@
2727
.cfi_adjust_cfa_offset PPC_MIN_STKFRM
2828
PPC_STL r0, PPC_MIN_STKFRM + PPC_LR_STKOFF(r1)
2929
.cfi_rel_offset lr, PPC_MIN_STKFRM + PPC_LR_STKOFF
30+
#ifdef __powerpc64__
31+
PPC_STL r2, PPC_MIN_STKFRM + STK_GOT(r1)
32+
.cfi_rel_offset r2, PPC_MIN_STKFRM + STK_GOT
33+
#endif
3034
get_realdatapage r8, r11
3135
addi r8, r8, VDSO_RNG_DATA_OFFSET
3236
bl CFUNC(DOTSYM(\funct))
3337
PPC_LL r0, PPC_MIN_STKFRM + PPC_LR_STKOFF(r1)
38+
#ifdef __powerpc64__
39+
PPC_LL r2, PPC_MIN_STKFRM + STK_GOT(r1)
40+
.cfi_restore r2
41+
#endif
3442
cmpwi r3, 0
3543
mtlr r0
3644
addi r1, r1, 2 * PPC_MIN_STKFRM

arch/powerpc/kernel/vdso/vdso64.lds.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ VERSION
123123
__kernel_sigtramp_rt64;
124124
__kernel_getcpu;
125125
__kernel_time;
126+
__kernel_getrandom;
126127

127128
local: *;
128129
};

arch/powerpc/kernel/vdso/vgetrandom-chacha.S

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,26 @@
124124
*/
125125
SYM_FUNC_START(__arch_chacha20_blocks_nostack)
126126
#ifdef __powerpc64__
127+
std counter, -216(r1)
128+
129+
std r14, -144(r1)
130+
std r15, -136(r1)
131+
std r16, -128(r1)
132+
std r17, -120(r1)
133+
std r18, -112(r1)
134+
std r19, -104(r1)
135+
std r20, -96(r1)
136+
std r21, -88(r1)
137+
std r22, -80(r1)
138+
std r23, -72(r1)
139+
std r24, -64(r1)
140+
std r25, -56(r1)
141+
std r26, -48(r1)
142+
std r27, -40(r1)
143+
std r28, -32(r1)
144+
std r29, -24(r1)
145+
std r30, -16(r1)
146+
std r31, -8(r1)
127147
#else
128148
stwu r1, -96(r1)
129149
stw counter, 20(r1)
@@ -149,9 +169,13 @@ SYM_FUNC_START(__arch_chacha20_blocks_nostack)
149169
stw r30, 88(r1)
150170
stw r31, 92(r1)
151171
#endif
172+
#endif /* __powerpc64__ */
152173

153174
lwz counter0, 0(counter)
154175
lwz counter1, 4(counter)
176+
#ifdef __powerpc64__
177+
rldimi counter0, counter1, 32, 0
178+
#endif
155179
mr idx_r0, nblocks
156180
subi dst_bytes, dst_bytes, 4
157181

@@ -267,12 +291,21 @@ SYM_FUNC_START(__arch_chacha20_blocks_nostack)
267291

268292
subic. idx_r0, idx_r0, 1 /* subi. can't use r0 as source */
269293

294+
#ifdef __powerpc64__
295+
addi counter0, counter0, 1
296+
srdi counter1, counter0, 32
297+
#else
270298
addic counter0, counter0, 1
271299
addze counter1, counter1
300+
#endif
272301

273302
bne .Lblock
274303

304+
#ifdef __powerpc64__
305+
ld counter, -216(r1)
306+
#else
275307
lwz counter, 20(r1)
308+
#endif
276309
stw counter0, 0(counter)
277310
stw counter1, 4(counter)
278311

@@ -284,6 +317,26 @@ SYM_FUNC_START(__arch_chacha20_blocks_nostack)
284317
li r11, 0
285318
li r12, 0
286319

320+
#ifdef __powerpc64__
321+
ld r14, -144(r1)
322+
ld r15, -136(r1)
323+
ld r16, -128(r1)
324+
ld r17, -120(r1)
325+
ld r18, -112(r1)
326+
ld r19, -104(r1)
327+
ld r20, -96(r1)
328+
ld r21, -88(r1)
329+
ld r22, -80(r1)
330+
ld r23, -72(r1)
331+
ld r24, -64(r1)
332+
ld r25, -56(r1)
333+
ld r26, -48(r1)
334+
ld r27, -40(r1)
335+
ld r28, -32(r1)
336+
ld r29, -24(r1)
337+
ld r30, -16(r1)
338+
ld r31, -8(r1)
339+
#else
287340
#ifdef __BIG_ENDIAN__
288341
lmw r14, 24(r1)
289342
#else

0 commit comments

Comments
 (0)