Skip to content

Commit 83bfd7a

Browse files
abelvesagregkh
authored andcommitted
spmi: pmic-arb: Fix some compile warnings about members not being described
Fix the following compile warnings: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' Reviewed-by: Neil Armstrong <[email protected]> Signed-off-by: Abel Vesa <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 345fbbc commit 83bfd7a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/spmi/spmi-pmic-arb.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ struct apid_data {
132132
* @wr_base: on v1 "core", on v2 "chnls" register base off DT.
133133
* @intr: address of the SPMI interrupt control registers.
134134
* @cnfg: address of the PMIC Arbiter configuration registers.
135+
* @core: core register base for v2 and above only (see above)
136+
* @core_size: core register base size
135137
* @lock: lock to synchronize accesses.
136138
* @channel: execution environment channel to use for accesses.
137139
* @irq: PMIC ARB interrupt.
@@ -144,6 +146,7 @@ struct apid_data {
144146
* @apid_count: on v5 and v7: number of APIDs associated with the
145147
* particular SPMI bus instance
146148
* @mapping_table: in-memory copy of PPID -> APID mapping table.
149+
* @mapping_table_valid:bitmap containing valid-only periphs
147150
* @domain: irq domain object for PMIC IRQ domain
148151
* @spmic: SPMI controller object
149152
* @ver_ops: version dependent operations.
@@ -232,6 +235,7 @@ static inline void pmic_arb_set_rd_cmd(struct spmi_pmic_arb *pmic_arb,
232235

233236
/**
234237
* pmic_arb_read_data: reads pmic-arb's register and copy 1..4 bytes to buf
238+
* @pmic_arb: the SPMI PMIC arbiter
235239
* @bc: byte count -1. range: 0..3
236240
* @reg: register's address
237241
* @buf: output parameter, length must be bc + 1
@@ -246,6 +250,7 @@ pmic_arb_read_data(struct spmi_pmic_arb *pmic_arb, u8 *buf, u32 reg, u8 bc)
246250

247251
/**
248252
* pmic_arb_write_data: write 1..4 bytes from buf to pmic-arb's register
253+
* @pmic_arb: the SPMI PMIC arbiter
249254
* @bc: byte-count -1. range: 0..3.
250255
* @reg: register's address.
251256
* @buf: buffer to write. length must be bc + 1.

0 commit comments

Comments
 (0)