Skip to content

Commit 88fee1c

Browse files
Bhawanpreet LakhaLyude
authored andcommitted
drm/dp_mst: Don't return error code when crtc is null
[Why] In certain cases the crtc can be NULL and returning -EINVAL causes atomic check to fail when it shouln't. This leads to valid configurations failing because atomic check fails. [How] Don't early return if crtc is null Signed-off-by: Bhawanpreet Lakha <[email protected]> Reviewed-by: Lyude Paul <[email protected]> [added stable cc] Signed-off-by: Lyude Paul <[email protected]> Fixes: 8ec0467 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs") Cc: <[email protected]> # v5.6+ Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 836b194 commit 88fee1c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/drm_dp_mst_topology.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4990,8 +4990,8 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drm
49904990

49914991
crtc = conn_state->crtc;
49924992

4993-
if (WARN_ON(!crtc))
4994-
return -EINVAL;
4993+
if (!crtc)
4994+
continue;
49954995

49964996
if (!drm_dp_mst_dsc_aux_for_port(pos->port))
49974997
continue;

0 commit comments

Comments
 (0)