Skip to content

Commit 89abe62

Browse files
Paolo Abenikuba-moo
authored andcommitted
selftests: net: give more time for GRO aggregation
The gro.sh test-case relay on the gro_flush_timeout to ensure that all the segments belonging to any given batch are properly aggregated. The other end, the sender is a user-space program transmitting each packet with a separate write syscall. A busy host and/or stracing the sender program can make the relevant segments reach the GRO engine after the flush timeout triggers. Give the GRO flush timeout more slack, to avoid sporadic self-tests failures. Fixes: 9af771d ("selftests/net: allow GRO coalesce test on veth") Signed-off-by: Paolo Abeni <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Tested-by: Eric Dumazet <[email protected]> Link: https://lore.kernel.org/r/bffec2beab3a5672dd13ecabe4fad81d2155b367.1706206101.git.pabeni@redhat.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent d3cb3b0 commit 89abe62

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/net/setup_veth.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ setup_veth_ns() {
1111
local -r ns_mac="$4"
1212

1313
[[ -e /var/run/netns/"${ns_name}" ]] || ip netns add "${ns_name}"
14-
echo 100000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
14+
echo 1000000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
1515
ip link set dev "${ns_dev}" netns "${ns_name}" mtu 65535
1616
ip -netns "${ns_name}" link set dev "${ns_dev}" up
1717

0 commit comments

Comments
 (0)