Skip to content

Commit 8b34b52

Browse files
geliangtangkuba-moo
authored andcommitted
mptcp: use nlmsg_free instead of kfree_skb
Use nlmsg_free() instead of kfree_skb() in pm_netlink.c. The SKB's have been created by nlmsg_new(). The proper cleaning way should then be done with nlmsg_free(). For the moment, nlmsg_free() is simply calling kfree_skb() so we don't change the behaviour here. Suggested-by: Jakub Kicinski <[email protected]> Reviewed-by: Matthieu Baerts <[email protected]> Signed-off-by: Geliang Tang <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c80edd8 commit 8b34b52

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/mptcp/pm_netlink.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2094,7 +2094,7 @@ void mptcp_event_addr_removed(const struct mptcp_sock *msk, uint8_t id)
20942094
return;
20952095

20962096
nla_put_failure:
2097-
kfree_skb(skb);
2097+
nlmsg_free(skb);
20982098
}
20992099

21002100
void mptcp_event_addr_announced(const struct sock *ssk,
@@ -2151,7 +2151,7 @@ void mptcp_event_addr_announced(const struct sock *ssk,
21512151
return;
21522152

21532153
nla_put_failure:
2154-
kfree_skb(skb);
2154+
nlmsg_free(skb);
21552155
}
21562156

21572157
void mptcp_event_pm_listener(const struct sock *ssk,
@@ -2203,7 +2203,7 @@ void mptcp_event_pm_listener(const struct sock *ssk,
22032203
return;
22042204

22052205
nla_put_failure:
2206-
kfree_skb(skb);
2206+
nlmsg_free(skb);
22072207
}
22082208

22092209
void mptcp_event(enum mptcp_event_type type, const struct mptcp_sock *msk,
@@ -2261,7 +2261,7 @@ void mptcp_event(enum mptcp_event_type type, const struct mptcp_sock *msk,
22612261
return;
22622262

22632263
nla_put_failure:
2264-
kfree_skb(skb);
2264+
nlmsg_free(skb);
22652265
}
22662266

22672267
static const struct genl_small_ops mptcp_pm_ops[] = {

0 commit comments

Comments
 (0)