Skip to content

Commit 8e3a90f

Browse files
Michal Swiatkowskianguy11
authored andcommitted
ice: remove correct filters during eswitch release
ice_clear_dflt_vsi() is only removing default rule. Both default RX and TX rule should be removed during release. If it isn't switching to switchdev, second time results in error, because TX filter is already there. Fix it by removing the correct set of rules. Fixes: 50d6202 ("ice: default Tx rule instead of to queue") Reviewed-by: Wojciech Drewek <[email protected]> Signed-off-by: Michal Swiatkowski <[email protected]> Signed-off-by: Marcin Szycik <[email protected]> Reviewed-by: Simon Horman <[email protected]> Tested-by: Sujai Buvaneswaran <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent fb324f2 commit 8e3a90f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/intel/ice/ice_eswitch.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,10 @@ static void ice_eswitch_release_env(struct ice_pf *pf)
246246
ice_vsi_update_local_lb(uplink_vsi, false);
247247
ice_vsi_update_security(uplink_vsi, ice_vsi_ctx_clear_allow_override);
248248
vlan_ops->ena_rx_filtering(uplink_vsi);
249-
ice_clear_dflt_vsi(uplink_vsi);
249+
ice_cfg_dflt_vsi(uplink_vsi->port_info, uplink_vsi->idx, false,
250+
ICE_FLTR_TX);
251+
ice_cfg_dflt_vsi(uplink_vsi->port_info, uplink_vsi->idx, false,
252+
ICE_FLTR_RX);
250253
ice_fltr_add_mac_and_broadcast(uplink_vsi,
251254
uplink_vsi->port_info->mac.perm_addr,
252255
ICE_FWD_TO_VSI);

0 commit comments

Comments
 (0)