Skip to content

Commit 8e7d3f6

Browse files
Sathya Perladavem330
authored andcommitted
be2net: fix multicast filter programming
Re-posting with subject fixed! Multicast programming has been broken since commit 5b8821b. Setting the MULTICAST flag while sending the cmd to the FW was missing. Fixed this. Also fixed-up some indentation in the adjacent lines. Signed-off-by: Sathya Perla <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4de075e commit 8e7d3f6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/net/ethernet/emulex/benet/be_cmds.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,14 +1580,16 @@ int be_cmd_rx_filter(struct be_adapter *adapter, u32 flags, u32 value)
15801580
BE_IF_FLAGS_VLAN_PROMISCUOUS);
15811581
if (value == ON)
15821582
req->if_flags = cpu_to_le32(BE_IF_FLAGS_PROMISCUOUS |
1583-
BE_IF_FLAGS_VLAN_PROMISCUOUS);
1583+
BE_IF_FLAGS_VLAN_PROMISCUOUS);
15841584
} else if (flags & IFF_ALLMULTI) {
15851585
req->if_flags_mask = req->if_flags =
1586-
cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS);
1586+
cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS);
15871587
} else {
15881588
struct netdev_hw_addr *ha;
15891589
int i = 0;
15901590

1591+
req->if_flags_mask = req->if_flags =
1592+
cpu_to_le32(BE_IF_FLAGS_MULTICAST);
15911593
req->mcast_num = cpu_to_le16(netdev_mc_count(adapter->netdev));
15921594
netdev_for_each_mc_addr(ha, adapter->netdev)
15931595
memcpy(req->mcast_mac[i++].byte, ha->addr, ETH_ALEN);

0 commit comments

Comments
 (0)