Skip to content

Commit 93e0401

Browse files
ffainellidavem330
authored andcommitted
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
The call to phy_stop() races with the later call to phy_disconnect(), resulting in concurrent phy_suspend() calls being run from different CPUs. The final call to phy_disconnect() ensures that the PHY is stopped and suspended, too. Fixes: c96e731 ("net: bcmgenet: connect and disconnect from the PHY state machine") Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1e76f42 commit 93e0401

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/broadcom/genet/bcmgenet.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3465,7 +3465,6 @@ static void bcmgenet_netif_stop(struct net_device *dev)
34653465
/* Disable MAC transmit. TX DMA disabled must be done before this */
34663466
umac_enable_set(priv, CMD_TX_EN, false);
34673467

3468-
phy_stop(dev->phydev);
34693468
bcmgenet_disable_rx_napi(priv);
34703469
bcmgenet_intr_disable(priv);
34713470

0 commit comments

Comments
 (0)