Skip to content

Commit 96e20ad

Browse files
M-Vaittinenbroonie
authored andcommitted
regulator: change stubbed devm_regulator_get_enable to return Ok
The devm_regulator_get_enable() should be a 'call and forget' API, meaning, when it is used to enable the regulators, the API does not provide a handle to do any further control of the regulators. It gives no real benefit to return an error from the stub if CONFIG_REGULATOR is not set. On the contrary, returning and error is causing problems to drivers when hardware is such it works out just fine with no regulator control. Returning an error forces drivers to specifically handle the case where CONFIG_REGULATOR is not set, making the mere existence of the stub questionalble. Furthermore, the stub of the regulator_enable() seems to be returning Ok. Change the stub implementation for the devm_regulator_get_enable() to return Ok so drivers do not separately handle the case where the CONFIG_REGULATOR is not set. Signed-off-by: Matti Vaittinen <[email protected]> Reported-by: Aleksander Mazur <[email protected]> Suggested-by: Guenter Roeck <[email protected]> Fixes: da279e6 ("regulator: Add devm helpers for get and enable") Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 68adb58 commit 96e20ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/regulator/consumer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ devm_regulator_get_exclusive(struct device *dev, const char *id)
320320

321321
static inline int devm_regulator_get_enable(struct device *dev, const char *id)
322322
{
323-
return -ENODEV;
323+
return 0;
324324
}
325325

326326
static inline int devm_regulator_get_enable_optional(struct device *dev,

0 commit comments

Comments
 (0)