Skip to content

Commit 96f7993

Browse files
Sam Protsenkokrzk
authored andcommitted
pinctrl: samsung: Remove EINT handler for Exynos850 ALIVE and CMGP gpios
GPIO_ALIVE and GPIO_CMGP blocks in Exynos850 SoC don't have EINT capabilities (like EINT_SVC register), and there are no corresponding interrupts wired to GIC. Instead those blocks have wake-up interrupts for each pin. The ".eint_gpio_init" callbacks were specified by mistake for these blocks, when porting pinctrl code from downstream kernel. That leads to error messages like this: samsung-pinctrl 11850000.pinctrl: irq number not available Remove ".eint_gpio_init" for pinctrl_alive and pinctrl_gpmc to fix this error. This change doesn't affect proper interrupt handling for related pins, as all those pins are handled in ".eint_wkup_init". Fixes: cdd3d94 ("pinctrl: samsung: Add Exynos850 SoC specific data") Signed-off-by: Sam Protsenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent 50ebd19 commit 96f7993

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/pinctrl/samsung/pinctrl-exynos-arm64.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,13 +585,11 @@ static const struct samsung_pin_ctrl exynos850_pin_ctrl[] __initconst = {
585585
/* pin-controller instance 0 ALIVE data */
586586
.pin_banks = exynos850_pin_banks0,
587587
.nr_banks = ARRAY_SIZE(exynos850_pin_banks0),
588-
.eint_gpio_init = exynos_eint_gpio_init,
589588
.eint_wkup_init = exynos_eint_wkup_init,
590589
}, {
591590
/* pin-controller instance 1 CMGP data */
592591
.pin_banks = exynos850_pin_banks1,
593592
.nr_banks = ARRAY_SIZE(exynos850_pin_banks1),
594-
.eint_gpio_init = exynos_eint_gpio_init,
595593
.eint_wkup_init = exynos_eint_wkup_init,
596594
}, {
597595
/* pin-controller instance 2 AUD data */

0 commit comments

Comments
 (0)