Skip to content

Commit 9a3c05e

Browse files
Zhenzhong Duanbonzini
authored andcommitted
xen: Mark "xen_nopvspin" parameter obsolete
Map "xen_nopvspin" to "nopvspin", fix stale description of "xen_nopvspin" as we use qspinlock now. Signed-off-by: Zhenzhong Duan <[email protected]> Reviewed-by: Boris Ostrovsky <[email protected]> Cc: Jonathan Corbet <[email protected]> Cc: Boris Ostrovsky <[email protected]> Cc: Juergen Gross <[email protected]> Cc: Stefano Stabellini <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Borislav Petkov <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 05eee61 commit 9a3c05e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5712,8 +5712,9 @@
57125712
panic() code such as dumping handler.
57135713

57145714
xen_nopvspin [X86,XEN]
5715-
Disables the ticketlock slowpath using Xen PV
5716-
optimizations.
5715+
Disables the qspinlock slowpath using Xen PV optimizations.
5716+
This parameter is obsoleted by "nopvspin" parameter, which
5717+
has equivalent effect for XEN platform.
57175718

57185719
xen_nopv [X86]
57195720
Disables the PV optimizations forcing the HVM guest to
@@ -5739,7 +5740,7 @@
57395740
as generic guest with no PV drivers. Currently support
57405741
XEN HVM, KVM, HYPER_V and VMWARE guest.
57415742

5742-
nopvspin [X86,KVM]
5743+
nopvspin [X86,XEN,KVM]
57435744
Disables the qspinlock slow path using PV optimizations
57445745
which allow the hypervisor to 'idle' the guest on lock
57455746
contention.

arch/x86/xen/spinlock.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,8 @@ PV_CALLEE_SAVE_REGS_THUNK(xen_vcpu_stolen);
114114
*/
115115
void __init xen_init_spinlocks(void)
116116
{
117-
118117
/* Don't need to use pvqspinlock code if there is only 1 vCPU. */
119-
if (num_possible_cpus() == 1)
118+
if (num_possible_cpus() == 1 || nopvspin)
120119
xen_pvspin = false;
121120

122121
if (!xen_pvspin) {
@@ -137,6 +136,7 @@ void __init xen_init_spinlocks(void)
137136

138137
static __init int xen_parse_nopvspin(char *arg)
139138
{
139+
pr_notice("\"xen_nopvspin\" is deprecated, please use \"nopvspin\" instead\n");
140140
xen_pvspin = false;
141141
return 0;
142142
}

0 commit comments

Comments
 (0)