Skip to content

Commit 9a58480

Browse files
lategoodbyeKAGA-KOKO
authored andcommitted
irqchip/bcm2835: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND
The BCM2835 ARMCTRL interrupt controller doesn't provide any facility to configure the wakeup sources. That's the reason why the driver lacks the irq_set_wake() callback for the interrupt chip. But this prevent to properly enter power management states like "suspend to idle". Enable the flags IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND so the interrupt suspend logic can handle the chip correctly. Signed-off-by: Stefan Wahren <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Reviewed-by: Florian Fainelli <[email protected]>
1 parent a84a07f commit 9a58480

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/irqchip/irq-bcm2835.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ static void armctrl_unmask_irq(struct irq_data *d)
102102
static struct irq_chip armctrl_chip = {
103103
.name = "ARMCTRL-level",
104104
.irq_mask = armctrl_mask_irq,
105-
.irq_unmask = armctrl_unmask_irq
105+
.irq_unmask = armctrl_unmask_irq,
106+
.flags = IRQCHIP_MASK_ON_SUSPEND |
107+
IRQCHIP_SKIP_SET_WAKE,
106108
};
107109

108110
static int armctrl_xlate(struct irq_domain *d, struct device_node *ctrlr,

0 commit comments

Comments
 (0)