Skip to content

Commit 9dbb58d

Browse files
Kurt Van Dijckdavem330
authored andcommitted
can: sja1000: fix bug using library functions for skb allocation
Commit 7b6856a "can: provide library functions for skb allocation" did not properly remove two lines of the SJA1000 driver resulting in a 'skb_over_panic' when calling skb_put, as reported by Kurt. Signed-off-by: Kurt Van Dijck <[email protected]> Signed-off-by: Wolfgang Grandegger <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 10e85f7 commit 9dbb58d

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/net/can/sja1000/sja1000.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,6 @@ static void sja1000_rx(struct net_device *dev)
321321
if (fi & FI_RTR)
322322
id |= CAN_RTR_FLAG;
323323

324-
cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame));
325-
memset(cf, 0, sizeof(struct can_frame));
326324
cf->can_id = id;
327325
cf->can_dlc = dlc;
328326
for (i = 0; i < dlc; i++)

0 commit comments

Comments
 (0)