Skip to content

Commit a50e431

Browse files
robherringrobherring
committed
dt-bindings: media: mediatek,vcodec: Fix addressing cell sizes
'dma-ranges' in the example is written for cell sizes of 2 cells, but the schema and example specify sizes of 1 cell. As the h/w has a bus address of >32-bits, cell sizes of 2 is correct. Update the schema's '#address-cells' and '#size-cells' to be 2 and adjust the example throughout. There's no error currently because dtc only checks 'dma-ranges' is a correct multiple number of cells (3) and the schema checking is based on bracketing of entries. Signed-off-by: Rob Herring <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 09a2fb4 commit a50e431

File tree

1 file changed

+64
-58
lines changed

1 file changed

+64
-58
lines changed

‎Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml

Lines changed: 64 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ properties:
7272
Describes the physical address space of IOMMU maps to memory.
7373
7474
"#address-cells":
75-
const: 1
75+
const: 2
7676

7777
"#size-cells":
78-
const: 1
78+
const: 2
7979

8080
ranges: true
8181

@@ -205,61 +205,67 @@ examples:
205205
#include <dt-bindings/clock/mt8192-clk.h>
206206
#include <dt-bindings/power/mt8192-power.h>
207207
208-
video-codec@16000000 {
209-
compatible = "mediatek,mt8192-vcodec-dec";
210-
mediatek,scp = <&scp>;
211-
iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
212-
dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>;
213-
#address-cells = <1>;
214-
#size-cells = <1>;
215-
ranges = <0 0x16000000 0x40000>;
216-
reg = <0x16000000 0x1000>; /* VDEC_SYS */
217-
vcodec-lat@10000 {
218-
compatible = "mediatek,mtk-vcodec-lat";
219-
reg = <0x10000 0x800>;
220-
interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
221-
iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
222-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
223-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
224-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
225-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
226-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
227-
<&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
228-
<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
229-
clocks = <&topckgen CLK_TOP_VDEC_SEL>,
230-
<&vdecsys_soc CLK_VDEC_SOC_VDEC>,
231-
<&vdecsys_soc CLK_VDEC_SOC_LAT>,
232-
<&vdecsys_soc CLK_VDEC_SOC_LARB1>,
233-
<&topckgen CLK_TOP_MAINPLL_D4>;
234-
clock-names = "sel", "soc-vdec", "soc-lat", "vdec", "top";
235-
assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
236-
assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
237-
power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
238-
};
239-
240-
vcodec-core@25000 {
241-
compatible = "mediatek,mtk-vcodec-core";
242-
reg = <0x25000 0x1000>;
243-
interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>;
244-
iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>,
245-
<&iommu0 M4U_PORT_L4_VDEC_UFO_EXT>,
246-
<&iommu0 M4U_PORT_L4_VDEC_PP_EXT>,
247-
<&iommu0 M4U_PORT_L4_VDEC_PRED_RD_EXT>,
248-
<&iommu0 M4U_PORT_L4_VDEC_PRED_WR_EXT>,
249-
<&iommu0 M4U_PORT_L4_VDEC_PPWRAP_EXT>,
250-
<&iommu0 M4U_PORT_L4_VDEC_TILE_EXT>,
251-
<&iommu0 M4U_PORT_L4_VDEC_VLD_EXT>,
252-
<&iommu0 M4U_PORT_L4_VDEC_VLD2_EXT>,
253-
<&iommu0 M4U_PORT_L4_VDEC_AVC_MV_EXT>,
254-
<&iommu0 M4U_PORT_L4_VDEC_RG_CTRL_DMA_EXT>;
255-
clocks = <&topckgen CLK_TOP_VDEC_SEL>,
256-
<&vdecsys CLK_VDEC_VDEC>,
257-
<&vdecsys CLK_VDEC_LAT>,
258-
<&vdecsys CLK_VDEC_LARB1>,
259-
<&topckgen CLK_TOP_MAINPLL_D4>;
260-
clock-names = "sel", "soc-vdec", "soc-lat", "vdec", "top";
261-
assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
262-
assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
263-
power-domains = <&spm MT8192_POWER_DOMAIN_VDEC2>;
208+
bus@16000000 {
209+
#address-cells = <2>;
210+
#size-cells = <2>;
211+
ranges = <0 0x16000000 0x16000000 0 0x40000>;
212+
213+
video-codec@16000000 {
214+
compatible = "mediatek,mt8192-vcodec-dec";
215+
mediatek,scp = <&scp>;
216+
iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
217+
dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>;
218+
#address-cells = <2>;
219+
#size-cells = <2>;
220+
ranges = <0 0 0 0x16000000 0 0x40000>;
221+
reg = <0 0x16000000 0 0x1000>; /* VDEC_SYS */
222+
vcodec-lat@10000 {
223+
compatible = "mediatek,mtk-vcodec-lat";
224+
reg = <0 0x10000 0 0x800>;
225+
interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
226+
iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
227+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
228+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
229+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
230+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
231+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
232+
<&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
233+
<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
234+
clocks = <&topckgen CLK_TOP_VDEC_SEL>,
235+
<&vdecsys_soc CLK_VDEC_SOC_VDEC>,
236+
<&vdecsys_soc CLK_VDEC_SOC_LAT>,
237+
<&vdecsys_soc CLK_VDEC_SOC_LARB1>,
238+
<&topckgen CLK_TOP_MAINPLL_D4>;
239+
clock-names = "sel", "soc-vdec", "soc-lat", "vdec", "top";
240+
assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
241+
assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
242+
power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
243+
};
244+
245+
vcodec-core@25000 {
246+
compatible = "mediatek,mtk-vcodec-core";
247+
reg = <0 0x25000 0 0x1000>;
248+
interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>;
249+
iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>,
250+
<&iommu0 M4U_PORT_L4_VDEC_UFO_EXT>,
251+
<&iommu0 M4U_PORT_L4_VDEC_PP_EXT>,
252+
<&iommu0 M4U_PORT_L4_VDEC_PRED_RD_EXT>,
253+
<&iommu0 M4U_PORT_L4_VDEC_PRED_WR_EXT>,
254+
<&iommu0 M4U_PORT_L4_VDEC_PPWRAP_EXT>,
255+
<&iommu0 M4U_PORT_L4_VDEC_TILE_EXT>,
256+
<&iommu0 M4U_PORT_L4_VDEC_VLD_EXT>,
257+
<&iommu0 M4U_PORT_L4_VDEC_VLD2_EXT>,
258+
<&iommu0 M4U_PORT_L4_VDEC_AVC_MV_EXT>,
259+
<&iommu0 M4U_PORT_L4_VDEC_RG_CTRL_DMA_EXT>;
260+
clocks = <&topckgen CLK_TOP_VDEC_SEL>,
261+
<&vdecsys CLK_VDEC_VDEC>,
262+
<&vdecsys CLK_VDEC_LAT>,
263+
<&vdecsys CLK_VDEC_LARB1>,
264+
<&topckgen CLK_TOP_MAINPLL_D4>;
265+
clock-names = "sel", "soc-vdec", "soc-lat", "vdec", "top";
266+
assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
267+
assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
268+
power-domains = <&spm MT8192_POWER_DOMAIN_VDEC2>;
269+
};
264270
};
265271
};

0 commit comments

Comments
 (0)