Skip to content

Commit ae75415

Browse files
netoptimizerAlexei Starovoitov
authored andcommitted
mlx4: setup xdp_rxq_info
Driver hook points for xdp_rxq_info: * reg : mlx4_en_create_rx_ring * unreg: mlx4_en_destroy_rx_ring Tested on actual hardware. Cc: Tariq Toukan <[email protected]> Signed-off-by: Jesper Dangaard Brouer <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent c0124f3 commit ae75415

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2172,8 +2172,9 @@ static int mlx4_en_alloc_resources(struct mlx4_en_priv *priv)
21722172

21732173
if (mlx4_en_create_rx_ring(priv, &priv->rx_ring[i],
21742174
prof->rx_ring_size, priv->stride,
2175-
node))
2175+
node, i))
21762176
goto err;
2177+
21772178
}
21782179

21792180
#ifdef CONFIG_RFS_ACCEL

drivers/net/ethernet/mellanox/mlx4/en_rx.c

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev)
262262

263263
int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
264264
struct mlx4_en_rx_ring **pring,
265-
u32 size, u16 stride, int node)
265+
u32 size, u16 stride, int node, int queue_index)
266266
{
267267
struct mlx4_en_dev *mdev = priv->mdev;
268268
struct mlx4_en_rx_ring *ring;
@@ -286,14 +286,17 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
286286
ring->log_stride = ffs(ring->stride) - 1;
287287
ring->buf_size = ring->size * ring->stride + TXBB_SIZE;
288288

289+
if (xdp_rxq_info_reg(&ring->xdp_rxq, priv->dev, queue_index) < 0)
290+
goto err_ring;
291+
289292
tmp = size * roundup_pow_of_two(MLX4_EN_MAX_RX_FRAGS *
290293
sizeof(struct mlx4_en_rx_alloc));
291294
ring->rx_info = vzalloc_node(tmp, node);
292295
if (!ring->rx_info) {
293296
ring->rx_info = vzalloc(tmp);
294297
if (!ring->rx_info) {
295298
err = -ENOMEM;
296-
goto err_ring;
299+
goto err_xdp_info;
297300
}
298301
}
299302

@@ -317,6 +320,8 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
317320
err_info:
318321
vfree(ring->rx_info);
319322
ring->rx_info = NULL;
323+
err_xdp_info:
324+
xdp_rxq_info_unreg(&ring->xdp_rxq);
320325
err_ring:
321326
kfree(ring);
322327
*pring = NULL;
@@ -440,6 +445,7 @@ void mlx4_en_destroy_rx_ring(struct mlx4_en_priv *priv,
440445
lockdep_is_held(&mdev->state_lock));
441446
if (old_prog)
442447
bpf_prog_put(old_prog);
448+
xdp_rxq_info_unreg(&ring->xdp_rxq);
443449
mlx4_free_hwq_res(mdev->dev, &ring->wqres, size * stride + TXBB_SIZE);
444450
vfree(ring->rx_info);
445451
ring->rx_info = NULL;
@@ -652,6 +658,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
652658
int cq_ring = cq->ring;
653659
bool doorbell_pending;
654660
struct mlx4_cqe *cqe;
661+
struct xdp_buff xdp;
655662
int polled = 0;
656663
int index;
657664

@@ -666,6 +673,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
666673
/* Protect accesses to: ring->xdp_prog, priv->mac_hash list */
667674
rcu_read_lock();
668675
xdp_prog = rcu_dereference(ring->xdp_prog);
676+
xdp.rxq = &ring->xdp_rxq;
669677
doorbell_pending = 0;
670678

671679
/* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx
@@ -750,7 +758,6 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
750758
* read bytes but not past the end of the frag.
751759
*/
752760
if (xdp_prog) {
753-
struct xdp_buff xdp;
754761
dma_addr_t dma;
755762
void *orig_data;
756763
u32 act;

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
#endif
4747
#include <linux/cpu_rmap.h>
4848
#include <linux/ptp_clock_kernel.h>
49+
#include <net/xdp.h>
4950

5051
#include <linux/mlx4/device.h>
5152
#include <linux/mlx4/qp.h>
@@ -356,6 +357,7 @@ struct mlx4_en_rx_ring {
356357
unsigned long dropped;
357358
int hwtstamp_rx_filter;
358359
cpumask_var_t affinity_mask;
360+
struct xdp_rxq_info xdp_rxq;
359361
};
360362

361363
struct mlx4_en_cq {
@@ -720,7 +722,7 @@ void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev);
720722
void mlx4_en_recover_from_oom(struct mlx4_en_priv *priv);
721723
int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
722724
struct mlx4_en_rx_ring **pring,
723-
u32 size, u16 stride, int node);
725+
u32 size, u16 stride, int node, int queue_index);
724726
void mlx4_en_destroy_rx_ring(struct mlx4_en_priv *priv,
725727
struct mlx4_en_rx_ring **pring,
726728
u32 size, u16 stride);

0 commit comments

Comments
 (0)