Skip to content

Commit aead342

Browse files
ColinIanKingKent Overstreet
authored andcommitted
bcachefs: remove redundant variable tmp
The variable tmp is being assigned a value but it isn't being read afterwards. The assignment is redundant and so tmp can be removed. Cleans up clang scan build warning: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] Signed-off-by: Colin Ian King <[email protected]> Reviewed-by: Brian Foster <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
1 parent b97de45 commit aead342

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

fs/bcachefs/rebalance.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -385,16 +385,14 @@ static int bch2_rebalance_thread(void *arg)
385385
struct bch_fs *c = arg;
386386
struct bch_fs_rebalance *r = &c->rebalance;
387387
struct moving_context ctxt;
388-
int ret;
389388

390389
set_freezable();
391390

392391
bch2_moving_ctxt_init(&ctxt, c, NULL, &r->work_stats,
393392
writepoint_ptr(&c->rebalance_write_point),
394393
true);
395394

396-
while (!kthread_should_stop() &&
397-
!(ret = do_rebalance(&ctxt)))
395+
while (!kthread_should_stop() && !do_rebalance(&ctxt))
398396
;
399397

400398
bch2_moving_ctxt_exit(&ctxt);

0 commit comments

Comments
 (0)