Skip to content

Commit affce9a

Browse files
Nikolay Aleksandrovdavem330
authored andcommitted
net: bridge: mcast: toggle also host vlan state in br_multicast_toggle_vlan
When changing vlan mcast state by br_multicast_toggle_vlan it iterates over all ports and enables/disables the port mcast ctx based on the new state, but I forgot to update the host vlan (bridge master vlan entry) with the new state so it will be left out. Also that function is not used outside of br_multicast.c, so make it static. Fixes: f4b7002 ("net: bridge: add vlan mcast snooping knob") Signed-off-by: Nikolay Aleksandrov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 3f0d14e commit affce9a

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

net/bridge/br_multicast.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4074,7 +4074,7 @@ void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan, bool on)
40744074
}
40754075
}
40764076

4077-
void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
4077+
static void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
40784078
{
40794079
struct net_bridge_port *p;
40804080

@@ -4089,6 +4089,9 @@ void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
40894089
continue;
40904090
br_multicast_toggle_one_vlan(vport, on);
40914091
}
4092+
4093+
if (br_vlan_is_brentry(vlan))
4094+
br_multicast_toggle_one_vlan(vlan, on);
40924095
}
40934096

40944097
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,

net/bridge/br_private.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,6 @@ void br_multicast_port_ctx_init(struct net_bridge_port *port,
938938
struct net_bridge_mcast_port *pmctx);
939939
void br_multicast_port_ctx_deinit(struct net_bridge_mcast_port *pmctx);
940940
void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan, bool on);
941-
void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on);
942941
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,
943942
struct netlink_ext_ack *extack);
944943
bool br_multicast_toggle_global_vlan(struct net_bridge_vlan *vlan, bool on);
@@ -1370,11 +1369,6 @@ static inline void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan,
13701369
{
13711370
}
13721371

1373-
static inline void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan,
1374-
bool on)
1375-
{
1376-
}
1377-
13781372
static inline int br_multicast_toggle_vlan_snooping(struct net_bridge *br,
13791373
bool on,
13801374
struct netlink_ext_ack *extack)

0 commit comments

Comments
 (0)