Skip to content

Commit b62e8df

Browse files
namhyungacmel
authored andcommitted
perf hists browser: Add 'L' hotkey to change percent limit
Add 'L' key action to change the percent limit applied to both of hist entries and callchains. Suggested-by: Arnaldo Carvalho de Melo <[email protected]> Signed-off-by: Namhyung Kim <[email protected]> Cc: Andi Kleen <[email protected]> Cc: David Ahern <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Cc: Wang Nan <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 1ba2fc6 commit b62e8df

File tree

1 file changed

+55
-0
lines changed

1 file changed

+55
-0
lines changed

tools/perf/ui/browsers/hists.c

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2029,6 +2029,42 @@ static void hist_browser__update_nr_entries(struct hist_browser *hb)
20292029
hb->nr_non_filtered_entries = nr_entries;
20302030
}
20312031

2032+
static void hist_browser__update_percent_limit(struct hist_browser *hb,
2033+
double percent)
2034+
{
2035+
struct hist_entry *he;
2036+
struct rb_node *nd = rb_first(&hb->hists->entries);
2037+
u64 total = hists__total_period(hb->hists);
2038+
u64 min_callchain_hits = total * (percent / 100);
2039+
2040+
hb->min_pcnt = callchain_param.min_percent = percent;
2041+
2042+
if (!symbol_conf.use_callchain)
2043+
return;
2044+
2045+
while ((nd = hists__filter_entries(nd, hb->min_pcnt)) != NULL) {
2046+
he = rb_entry(nd, struct hist_entry, rb_node);
2047+
2048+
if (callchain_param.mode == CHAIN_GRAPH_REL) {
2049+
total = he->stat.period;
2050+
2051+
if (symbol_conf.cumulate_callchain)
2052+
total = he->stat_acc->period;
2053+
2054+
min_callchain_hits = total * (percent / 100);
2055+
}
2056+
2057+
callchain_param.sort(&he->sorted_chain, he->callchain,
2058+
min_callchain_hits, &callchain_param);
2059+
2060+
/* force to re-evaluate folding state of callchains */
2061+
he->init_have_children = false;
2062+
hist_entry__set_folding(he, false);
2063+
2064+
nd = rb_next(nd);
2065+
}
2066+
}
2067+
20322068
static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
20332069
const char *helpline,
20342070
bool left_exits,
@@ -2064,6 +2100,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
20642100
"E Expand all callchains\n" \
20652101
"F Toggle percentage of filtered entries\n" \
20662102
"H Display column headers\n" \
2103+
"L Change percent limit\n" \
20672104
"m Display context menu\n" \
20682105
"S Zoom into current Processor Socket\n" \
20692106

@@ -2219,6 +2256,24 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
22192256
top->zero = !top->zero;
22202257
}
22212258
continue;
2259+
case 'L':
2260+
if (ui_browser__input_window("Percent Limit",
2261+
"Please enter the value you want to hide entries under that percent.",
2262+
buf, "ENTER: OK, ESC: Cancel",
2263+
delay_secs * 2) == K_ENTER) {
2264+
char *end;
2265+
double new_percent = strtod(buf, &end);
2266+
2267+
if (new_percent < 0 || new_percent > 100) {
2268+
ui_browser__warning(&browser->b, delay_secs * 2,
2269+
"Invalid percent: %.2f", new_percent);
2270+
continue;
2271+
}
2272+
2273+
hist_browser__update_percent_limit(browser, new_percent);
2274+
hist_browser__reset(browser);
2275+
}
2276+
continue;
22222277
case K_F1:
22232278
case 'h':
22242279
case '?':

0 commit comments

Comments
 (0)