Skip to content

Commit ba0294d

Browse files
author
Bartosz Golaszewski
committed
gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim()
Turns out we can avoid the memmove() by using skip_spaces() and strim(). We did that in gpio-consumer, let's do it in gpio-sim. Suggested-by: Andy Shevchenko <[email protected]> Signed-off-by: Bartosz Golaszewski <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]>
1 parent a40fe1f commit ba0294d

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

drivers/gpio/gpio-sim.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -642,16 +642,13 @@ static bool gpio_sim_device_is_live_unlocked(struct gpio_sim_device *dev)
642642

643643
static char *gpio_sim_strdup_trimmed(const char *str, size_t count)
644644
{
645-
char *dup, *trimmed;
645+
char *trimmed;
646646

647-
dup = kstrndup(str, count, GFP_KERNEL);
648-
if (!dup)
647+
trimmed = kstrndup(skip_spaces(str), count, GFP_KERNEL);
648+
if (!trimmed)
649649
return NULL;
650650

651-
trimmed = strstrip(dup);
652-
memmove(dup, trimmed, strlen(trimmed) + 1);
653-
654-
return dup;
651+
return strim(trimmed);
655652
}
656653

657654
static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,

0 commit comments

Comments
 (0)