Skip to content

Commit baee602

Browse files
committed
drm/vmwgfx: Remove vmw_chipset
vmw_chipset was duplicating pci_id. They are exactly the same variable just with two different names. Becuase pci_id was already used to detect the SVGA version, there's no point in having vmw_chipset and thus we can remove it. All references to vmw_chipset should use pci_id. Signed-off-by: Zack Rusin <[email protected]> Reviewed-by: Roland Scheidegger <[email protected]> Reviewed-by: Martin Krastev <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent b7d0949 commit baee602

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ static void vmw_vram_manager_fini(struct vmw_private *dev_priv)
706706
}
707707

708708
static int vmw_setup_pci_resources(struct vmw_private *dev,
709-
unsigned long pci_id)
709+
u32 pci_id)
710710
{
711711
resource_size_t rmmio_start;
712712
resource_size_t rmmio_size;
@@ -783,7 +783,7 @@ static int vmw_detect_version(struct vmw_private *dev)
783783
svga_id = vmw_read(dev, SVGA_REG_ID);
784784
if (svga_id != SVGA_ID_2 && svga_id != SVGA_ID_3) {
785785
DRM_ERROR("Unsupported SVGA ID 0x%x on chipset 0x%x\n",
786-
svga_id, dev->vmw_chipset);
786+
svga_id, dev->pci_id);
787787
return -ENOSYS;
788788
}
789789
BUG_ON(vmw_is_svga_v3(dev) && (svga_id != SVGA_ID_3));
@@ -798,7 +798,6 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id)
798798
bool refuse_dma = false;
799799
struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
800800

801-
dev_priv->vmw_chipset = pci_id;
802801
dev_priv->drm.dev_private = dev_priv;
803802

804803
mutex_init(&dev_priv->cmdbuf_mutex);

drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -487,8 +487,7 @@ struct vmw_private {
487487
struct ttm_device bdev;
488488

489489
struct drm_vma_offset_manager vma_manager;
490-
unsigned long pci_id;
491-
u32 vmw_chipset;
490+
u32 pci_id;
492491
resource_size_t io_start;
493492
resource_size_t vram_start;
494493
resource_size_t vram_size;

0 commit comments

Comments
 (0)