You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
clk: Skip clk provider registration when np is NULL
commit 6579c8d ("clk: Mark fwnodes when their clock provider is added")
revealed that clk/bcm/clk-raspberrypi.c driver calls
devm_of_clk_add_hw_provider(), with a NULL dev->of_node, which resulted in a
NULL pointer dereference in of_clk_add_hw_provider() when calling
fwnode_dev_initialized().
Returning 0 is reducing the if conditions in driver code and is being
consistent with the CONFIG_OF=n inline stub that returns 0 when CONFIG_OF
is disabled. The downside is that drivers will maybe register clkdev lookups
when they don't need to and waste some memory.
Fixes: 6579c8d ("clk: Mark fwnodes when their clock provider is added")
Fixes: 3c9ea42 ("clk: Mark fwnodes when their clock provider is added/removed")
Reported-by: Marek Szyprowski <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
Reviewed-by: Saravana Kannan <[email protected]>
Reviewed-by: Nicolas Saenz Julienne <[email protected]>
Signed-off-by: Tudor Ambarus <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
0 commit comments