Skip to content

Commit bdfd720

Browse files
pcercueisravnborg
authored andcommitted
drm/panel: novatek,nt39016: Add missing CR to error messages
If you pass a string that is not terminated with a carriage return to dev_err(), it will eventually be printed with a carriage return, but not right away, since the kernel will wait for a pr_cont(). Signed-off-by: Paul Cercueil <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 5b44f12 commit bdfd720

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/gpu/drm/panel/panel-novatek-nt39016.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel)
124124

125125
err = regulator_enable(panel->supply);
126126
if (err) {
127-
dev_err(panel->dev, "Failed to enable power supply: %d", err);
127+
dev_err(panel->dev, "Failed to enable power supply: %d\n", err);
128128
return err;
129129
}
130130

@@ -143,7 +143,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel)
143143
err = regmap_multi_reg_write(panel->map, nt39016_panel_regs,
144144
ARRAY_SIZE(nt39016_panel_regs));
145145
if (err) {
146-
dev_err(panel->dev, "Failed to init registers: %d", err);
146+
dev_err(panel->dev, "Failed to init registers: %d\n", err);
147147
goto err_disable_regulator;
148148
}
149149

@@ -173,7 +173,7 @@ static int nt39016_enable(struct drm_panel *drm_panel)
173173
ret = regmap_write(panel->map, NT39016_REG_SYSTEM,
174174
NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY);
175175
if (ret) {
176-
dev_err(panel->dev, "Unable to enable panel: %d", ret);
176+
dev_err(panel->dev, "Unable to enable panel: %d\n", ret);
177177
return ret;
178178
}
179179

@@ -193,7 +193,7 @@ static int nt39016_disable(struct drm_panel *drm_panel)
193193
err = regmap_write(panel->map, NT39016_REG_SYSTEM,
194194
NT39016_SYSTEM_RESET_N);
195195
if (err) {
196-
dev_err(panel->dev, "Unable to disable panel: %d", err);
196+
dev_err(panel->dev, "Unable to disable panel: %d\n", err);
197197
return err;
198198
}
199199

@@ -261,34 +261,34 @@ static int nt39016_probe(struct spi_device *spi)
261261

262262
panel->supply = devm_regulator_get(dev, "power");
263263
if (IS_ERR(panel->supply)) {
264-
dev_err(dev, "Failed to get power supply");
264+
dev_err(dev, "Failed to get power supply\n");
265265
return PTR_ERR(panel->supply);
266266
}
267267

268268
panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
269269
if (IS_ERR(panel->reset_gpio)) {
270-
dev_err(dev, "Failed to get reset GPIO");
270+
dev_err(dev, "Failed to get reset GPIO\n");
271271
return PTR_ERR(panel->reset_gpio);
272272
}
273273

274274
spi->bits_per_word = 8;
275275
spi->mode = SPI_MODE_3 | SPI_3WIRE;
276276
err = spi_setup(spi);
277277
if (err) {
278-
dev_err(dev, "Failed to setup SPI");
278+
dev_err(dev, "Failed to setup SPI\n");
279279
return err;
280280
}
281281

282282
panel->map = devm_regmap_init_spi(spi, &nt39016_regmap_config);
283283
if (IS_ERR(panel->map)) {
284-
dev_err(dev, "Failed to init regmap");
284+
dev_err(dev, "Failed to init regmap\n");
285285
return PTR_ERR(panel->map);
286286
}
287287

288288
err = drm_panel_of_backlight(&panel->drm_panel);
289289
if (err) {
290290
if (err != -EPROBE_DEFER)
291-
dev_err(dev, "Failed to get backlight handle");
291+
dev_err(dev, "Failed to get backlight handle\n");
292292
return err;
293293
}
294294

0 commit comments

Comments
 (0)