Skip to content

Commit bed20c8

Browse files
andy-shevwsakernel
authored andcommitted
i2c: designware: Rename i2c_dw_probe() to i2c_dw_probe_master()
As a preparatory patch to support slave mode for PCI enumerated devices rename i2c_dw_probe() to i2c_dw_probe_master() and split common i2c_dw_probe() as inline helper. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 42ab001 commit bed20c8

File tree

5 files changed

+20
-10
lines changed

5 files changed

+20
-10
lines changed

drivers/i2c/busses/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ obj-$(CONFIG_I2C_CBUS_GPIO) += i2c-cbus-gpio.o
4949
obj-$(CONFIG_I2C_CPM) += i2c-cpm.o
5050
obj-$(CONFIG_I2C_DAVINCI) += i2c-davinci.o
5151
obj-$(CONFIG_I2C_DESIGNWARE_CORE) += i2c-designware-core.o
52-
i2c-designware-core-objs := i2c-designware-common.o i2c-designware-master.o
52+
i2c-designware-core-objs := i2c-designware-common.o
53+
i2c-designware-core-objs += i2c-designware-master.o
5354
ifeq ($(CONFIG_I2C_DESIGNWARE_SLAVE),y)
5455
i2c-designware-core-objs += i2c-designware-slave.o
5556
endif

drivers/i2c/busses/i2c-designware-core.h

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ static inline void __i2c_dw_disable_nowait(struct dw_i2c_dev *dev)
315315
void __i2c_dw_disable(struct dw_i2c_dev *dev);
316316

317317
extern void i2c_dw_configure_master(struct dw_i2c_dev *dev);
318-
extern int i2c_dw_probe(struct dw_i2c_dev *dev);
318+
extern int i2c_dw_probe_master(struct dw_i2c_dev *dev);
319319

320320
#if IS_ENABLED(CONFIG_I2C_DESIGNWARE_SLAVE)
321321
extern void i2c_dw_configure_slave(struct dw_i2c_dev *dev);
@@ -325,6 +325,19 @@ static inline void i2c_dw_configure_slave(struct dw_i2c_dev *dev) { }
325325
static inline int i2c_dw_probe_slave(struct dw_i2c_dev *dev) { return -EINVAL; }
326326
#endif
327327

328+
static inline int i2c_dw_probe(struct dw_i2c_dev *dev)
329+
{
330+
switch (dev->mode) {
331+
case DW_IC_SLAVE:
332+
return i2c_dw_probe_slave(dev);
333+
case DW_IC_MASTER:
334+
return i2c_dw_probe_master(dev);
335+
default:
336+
dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode);
337+
return -EINVAL;
338+
}
339+
}
340+
328341
static inline void i2c_dw_configure(struct dw_i2c_dev *dev)
329342
{
330343
if (i2c_detect_slave_mode(dev->dev))

drivers/i2c/busses/i2c-designware-master.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ static int i2c_dw_init_recovery_info(struct dw_i2c_dev *dev)
727727
return 0;
728728
}
729729

730-
int i2c_dw_probe(struct dw_i2c_dev *dev)
730+
int i2c_dw_probe_master(struct dw_i2c_dev *dev)
731731
{
732732
struct i2c_adapter *adap = &dev->adapter;
733733
unsigned long irq_flags;
@@ -794,7 +794,7 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
794794

795795
return ret;
796796
}
797-
EXPORT_SYMBOL_GPL(i2c_dw_probe);
797+
EXPORT_SYMBOL_GPL(i2c_dw_probe_master);
798798

799799
MODULE_DESCRIPTION("Synopsys DesignWare I2C bus master adapter");
800800
MODULE_LICENSE("GPL");

drivers/i2c/busses/i2c-designware-pcidrv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
271271
ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
272272
adap->nr = controller->bus_num;
273273

274-
r = i2c_dw_probe(dev);
274+
r = i2c_dw_probe_master(dev);
275275
if (r) {
276276
pci_free_irq_vectors(pdev);
277277
return r;

drivers/i2c/busses/i2c-designware-platdrv.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
331331

332332
pm_runtime_enable(&pdev->dev);
333333

334-
if (dev->mode == DW_IC_SLAVE)
335-
ret = i2c_dw_probe_slave(dev);
336-
else
337-
ret = i2c_dw_probe(dev);
338-
334+
ret = i2c_dw_probe(dev);
339335
if (ret)
340336
goto exit_probe;
341337

0 commit comments

Comments
 (0)