net: hns3: remove redundant assignment of l2_hdr to itself

Colin Ian King · davem330 · commit c264ed44d857 · 2019-05-08T09:44:37.000-07:00
The pointer l2_hdr is being assigned to itself, this is redundant
and can be removed.

Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Reviewed-by: Yunsheng Lin &lt;linyunsheng@huawei.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -810,7 +810,7 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto,
 			   u8 il4_proto, u32 *type_cs_vlan_tso,
 			   u32 *ol_type_vlan_len_msec)
 {
-	unsigned char *l2_hdr = l2_hdr = skb->data;
+	unsigned char *l2_hdr = skb->data;
 	u32 l4_proto = ol4_proto;
 	union l4_hdr_info l4;
 	union l3_hdr_info l3;

Original file line number	Diff line number	Diff line change
`@@ -810,7 +810,7 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto,`
`810`	`810`	`u8 il4_proto, u32 *type_cs_vlan_tso,`
`811`	`811`	`u32 *ol_type_vlan_len_msec)`
`812`	`812`	`{`
`813`		`- unsigned char *l2_hdr = l2_hdr = skb->data;`
	`813`	`+ unsigned char *l2_hdr = skb->data;`
`814`	`814`	`u32 l4_proto = ol4_proto;`
`815`	`815`	`union l4_hdr_info l4;`
`816`	`816`	`union l3_hdr_info l3;`