Skip to content

Commit d0de824

Browse files
Barry Songtorvalds
authored andcommitted
mm/gup_test: GUP_TEST depends on DEBUG_FS
Without DEBUG_FS, all the code in gup_benchmark becomes meaningless. For sure kernel provides debugfs stub while DEBUG_FS is disabled, but the point here is that GUP_TEST can do nothing without DEBUG_FS. [[email protected]: add comment as a prompt to users as commented by John and Randy] Link: https://lkml.kernel.org/r/[email protected] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Barry Song <[email protected]> Suggested-by: John Garry <[email protected]> Reviewed-by: John Hubbard <[email protected]> Acked-by: Randy Dunlap <[email protected]> Cc: Ralph Campbell <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent afaa788 commit d0de824

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

mm/Kconfig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -823,6 +823,7 @@ config PERCPU_STATS
823823

824824
config GUP_TEST
825825
bool "Enable infrastructure for get_user_pages()-related unit tests"
826+
depends on DEBUG_FS
826827
help
827828
Provides /sys/kernel/debug/gup_test, which in turn provides a way
828829
to make ioctl calls that can launch kernel-based unit tests for
@@ -840,6 +841,9 @@ config GUP_TEST
840841

841842
See tools/testing/selftests/vm/gup_test.c
842843

844+
comment "GUP_TEST needs to have DEBUG_FS enabled"
845+
depends on !GUP_TEST && !DEBUG_FS
846+
843847
config GUP_GET_PTE_LOW_HIGH
844848
bool
845849

0 commit comments

Comments
 (0)