Skip to content

Commit d16b77d

Browse files
committed
drm/msm/dpu: drop duplicate vig_sblk instances
After fixing scaler version we are sure that sm8450 and sc8280xp vig sblk's are duplicates of sm8250_vig_sblk and thus can be dropped. Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/530876/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Baryshkov <[email protected]>
1 parent 5a7e3c0 commit d16b77d

File tree

3 files changed

+8
-26
lines changed

3 files changed

+8
-26
lines changed

drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ static const struct dpu_ctl_cfg sc8280xp_ctl[] = {
8383

8484
static const struct dpu_sspp_cfg sc8280xp_sspp[] = {
8585
SSPP_BLK("sspp_0", SSPP_VIG0, 0x4000, 0x2ac, VIG_SC7180_MASK,
86-
sc8280xp_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
86+
sm8250_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
8787
SSPP_BLK("sspp_1", SSPP_VIG1, 0x6000, 0x2ac, VIG_SC7180_MASK,
88-
sc8280xp_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
88+
sm8250_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
8989
SSPP_BLK("sspp_2", SSPP_VIG2, 0x8000, 0x2ac, VIG_SC7180_MASK,
90-
sc8280xp_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
90+
sm8250_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
9191
SSPP_BLK("sspp_3", SSPP_VIG3, 0xa000, 0x2ac, VIG_SC7180_MASK,
92-
sc8280xp_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
92+
sm8250_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
9393
SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, 0x2ac, DMA_SDM845_MASK,
9494
sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA0),
9595
SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, 0x2ac, DMA_SDM845_MASK,

drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,13 @@ static const struct dpu_ctl_cfg sm8450_ctl[] = {
8484

8585
static const struct dpu_sspp_cfg sm8450_sspp[] = {
8686
SSPP_BLK("sspp_0", SSPP_VIG0, 0x4000, 0x32c, VIG_SC7180_MASK,
87-
sm8450_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
87+
sm8250_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
8888
SSPP_BLK("sspp_1", SSPP_VIG1, 0x6000, 0x32c, VIG_SC7180_MASK,
89-
sm8450_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
89+
sm8250_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
9090
SSPP_BLK("sspp_2", SSPP_VIG2, 0x8000, 0x32c, VIG_SC7180_MASK,
91-
sm8450_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
91+
sm8250_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
9292
SSPP_BLK("sspp_3", SSPP_VIG3, 0xa000, 0x32c, VIG_SC7180_MASK,
93-
sm8450_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
93+
sm8250_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
9494
SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, 0x32c, DMA_SDM845_MASK,
9595
sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA0),
9696
SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, 0x32c, DMA_SDM845_MASK,

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -432,15 +432,6 @@ static const struct dpu_sspp_sub_blks sm8250_vig_sblk_2 =
432432
static const struct dpu_sspp_sub_blks sm8250_vig_sblk_3 =
433433
_VIG_SBLK("3", 8, DPU_SSPP_SCALER_QSEED4);
434434

435-
static const struct dpu_sspp_sub_blks sm8450_vig_sblk_0 =
436-
_VIG_SBLK("0", 5, DPU_SSPP_SCALER_QSEED4);
437-
static const struct dpu_sspp_sub_blks sm8450_vig_sblk_1 =
438-
_VIG_SBLK("1", 6, DPU_SSPP_SCALER_QSEED4);
439-
static const struct dpu_sspp_sub_blks sm8450_vig_sblk_2 =
440-
_VIG_SBLK("2", 7, DPU_SSPP_SCALER_QSEED4);
441-
static const struct dpu_sspp_sub_blks sm8450_vig_sblk_3 =
442-
_VIG_SBLK("3", 8, DPU_SSPP_SCALER_QSEED4);
443-
444435
static const struct dpu_sspp_sub_blks sm8550_vig_sblk_0 =
445436
_VIG_SBLK("0", 7, DPU_SSPP_SCALER_QSEED4);
446437
static const struct dpu_sspp_sub_blks sm8550_vig_sblk_1 =
@@ -452,15 +443,6 @@ static const struct dpu_sspp_sub_blks sm8550_vig_sblk_3 =
452443
static const struct dpu_sspp_sub_blks sm8550_dma_sblk_4 = _DMA_SBLK("12", 5);
453444
static const struct dpu_sspp_sub_blks sm8550_dma_sblk_5 = _DMA_SBLK("13", 6);
454445

455-
static const struct dpu_sspp_sub_blks sc8280xp_vig_sblk_0 =
456-
_VIG_SBLK("0", 5, DPU_SSPP_SCALER_QSEED4);
457-
static const struct dpu_sspp_sub_blks sc8280xp_vig_sblk_1 =
458-
_VIG_SBLK("1", 6, DPU_SSPP_SCALER_QSEED4);
459-
static const struct dpu_sspp_sub_blks sc8280xp_vig_sblk_2 =
460-
_VIG_SBLK("2", 7, DPU_SSPP_SCALER_QSEED4);
461-
static const struct dpu_sspp_sub_blks sc8280xp_vig_sblk_3 =
462-
_VIG_SBLK("3", 8, DPU_SSPP_SCALER_QSEED4);
463-
464446
#define _VIG_SBLK_NOSCALE(num, sdma_pri) \
465447
{ \
466448
.maxdwnscale = SSPP_UNITY_SCALE, \

0 commit comments

Comments
 (0)