Skip to content

Commit d2a437e

Browse files
Asbjørn Sloth Tønnesenkuba-moo
authored andcommitted
net: qede: propagate extack through qede_flow_spec_validate()
Pass extack to qede_flow_spec_validate() when called in qede_flow_spec_to_rule(). Pass extack to qede_parse_actions(). Not converting qede_flow_spec_validate() to use extack for errors, as it's only called from qede_flow_spec_to_rule(), where extack is faked into a DP_NOTICE anyway, so opting to keep DP_VERBOSE/DP_NOTICE usage. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent eb705d7 commit d2a437e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/net/ethernet/qlogic/qede/qede_filter.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1953,7 +1953,8 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto,
19531953
static int qede_flow_spec_validate(struct qede_dev *edev,
19541954
struct flow_action *flow_action,
19551955
struct qede_arfs_tuple *t,
1956-
__u32 location)
1956+
__u32 location,
1957+
struct netlink_ext_ack *extack)
19571958
{
19581959
int err;
19591960

@@ -1977,7 +1978,7 @@ static int qede_flow_spec_validate(struct qede_dev *edev,
19771978
return -EINVAL;
19781979
}
19791980

1980-
err = qede_parse_actions(edev, flow_action, NULL);
1981+
err = qede_parse_actions(edev, flow_action, extack);
19811982
if (err)
19821983
return err;
19831984

@@ -2024,7 +2025,7 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
20242025

20252026
/* Make sure location is valid and filter isn't already set */
20262027
err = qede_flow_spec_validate(edev, &flow->rule->action, t,
2027-
fs->location);
2028+
fs->location, &extack);
20282029
err_out:
20292030
if (extack._msg)
20302031
DP_NOTICE(edev, "%s\n", extack._msg);

0 commit comments

Comments
 (0)