Skip to content

Commit d423b96

Browse files
alexandrebelloniFelipe Balbi
authored andcommitted
usb: gadget: udc: atmel: Remove unnecessary macros
commit 46ddd79 ("usb: gadget: udc: atmel: Remove AVR32 bits from the driver") left the accessor macros introduced by commit a3dd3be ("usb: gadget: atmel_usba: use endian agnostic IO on ARM"). They can now be removed. Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
1 parent c8e4e5b commit d423b96

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

drivers/usb/gadget/udc/atmel_usba_udc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ static int regs_dbg_open(struct inode *inode, struct file *file)
152152

153153
spin_lock_irq(&udc->lock);
154154
for (i = 0; i < inode->i_size / 4; i++)
155-
data[i] = usba_io_readl(udc->regs + i * 4);
155+
data[i] = readl_relaxed(udc->regs + i * 4);
156156
spin_unlock_irq(&udc->lock);
157157

158158
file->private_data = data;
@@ -1369,7 +1369,7 @@ static int handle_ep0_setup(struct usba_udc *udc, struct usba_ep *ep,
13691369
if (crq->wLength != cpu_to_le16(sizeof(status)))
13701370
goto stall;
13711371
ep->state = DATA_STAGE_IN;
1372-
usba_io_writew(status, ep->fifo);
1372+
writew_relaxed(status, ep->fifo);
13731373
usba_ep_writel(ep, SET_STA, USBA_TX_PK_RDY);
13741374
break;
13751375
}

drivers/usb/gadget/udc/atmel_usba_udc.h

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -186,22 +186,18 @@
186186
| USBA_BF(name, value))
187187

188188
/* Register access macros */
189-
#define usba_io_readl readl_relaxed
190-
#define usba_io_writel writel_relaxed
191-
#define usba_io_writew writew_relaxed
192-
193189
#define usba_readl(udc, reg) \
194-
usba_io_readl((udc)->regs + USBA_##reg)
190+
readl_relaxed((udc)->regs + USBA_##reg)
195191
#define usba_writel(udc, reg, value) \
196-
usba_io_writel((value), (udc)->regs + USBA_##reg)
192+
writel_relaxed((value), (udc)->regs + USBA_##reg)
197193
#define usba_ep_readl(ep, reg) \
198-
usba_io_readl((ep)->ep_regs + USBA_EPT_##reg)
194+
readl_relaxed((ep)->ep_regs + USBA_EPT_##reg)
199195
#define usba_ep_writel(ep, reg, value) \
200-
usba_io_writel((value), (ep)->ep_regs + USBA_EPT_##reg)
196+
writel_relaxed((value), (ep)->ep_regs + USBA_EPT_##reg)
201197
#define usba_dma_readl(ep, reg) \
202-
usba_io_readl((ep)->dma_regs + USBA_DMA_##reg)
198+
readl_relaxed((ep)->dma_regs + USBA_DMA_##reg)
203199
#define usba_dma_writel(ep, reg, value) \
204-
usba_io_writel((value), (ep)->dma_regs + USBA_DMA_##reg)
200+
writel_relaxed((value), (ep)->dma_regs + USBA_DMA_##reg)
205201

206202
/* Calculate base address for a given endpoint or DMA controller */
207203
#define USBA_EPT_BASE(x) (0x100 + (x) * 0x20)

0 commit comments

Comments
 (0)