Skip to content

Commit d50318f

Browse files
captain5050namhyung
authored andcommitted
perf test: Reduce scope of parallel variable
The variable duplicates sequential but is only used for command line argument processing. Reduce scope to make the behavior clearer. Tested-by: James Clark <[email protected]> Signed-off-by: Ian Rogers <[email protected]> Cc: Colin Ian King <[email protected]> Cc: Howard Chu <[email protected]> Cc: Weilin Wang <[email protected]> Cc: Ilya Leoshkevich <[email protected]> Cc: Thomas Richter <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Dapeng Mi <[email protected]> Cc: Athira Jajeev <[email protected]> Cc: Michael Petlan <[email protected]> Cc: Veronika Molnarova <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Namhyung Kim <[email protected]>
1 parent 0e036dc commit d50318f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tools/perf/tests/builtin-test.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
static bool dont_fork;
4242
/* Don't fork the tests in parallel and wait for their completion. */
4343
static bool sequential = true;
44-
/* Do it in parallel, lacks infrastructure to avoid running tests that clash for resources,
45-
* So leave it as the developers choice to enable while working on the needed infra */
46-
static bool parallel;
4744
const char *dso_to_test;
4845
const char *test_objdump_path = "objdump";
4946

@@ -578,6 +575,12 @@ int cmd_test(int argc, const char **argv)
578575
const char *skip = NULL;
579576
const char *workload = NULL;
580577
bool list_workloads = false;
578+
/*
579+
* Run tests in parallel, lacks infrastructure to avoid running tests
580+
* that clash for resources, So leave it as the developers choice to
581+
* enable while working on the needed infra.
582+
*/
583+
bool parallel = false;
581584
const struct option test_options[] = {
582585
OPT_STRING('s', "skip", &skip, "tests", "tests to skip"),
583586
OPT_INCR('v', "verbose", &verbose,

0 commit comments

Comments
 (0)