Skip to content

Commit d5359a7

Browse files
kirankrishnappa-intelVudentz
authored andcommitted
Bluetooth: btintel: Direct exception event to bluetooth stack
Have exception event part of HCI traces which helps for debug. snoop traces: > HCI Event: Vendor (0xff) plen 79 Vendor Prefix (0x8780) Intel Extended Telemetry (0x03) Unknown extended telemetry event type (0xde) 01 01 de Unknown extended subevent 0x07 01 01 de 07 01 de 06 1c ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de 05 14 ef be ad de ef be ad de ef be ad de ef be ad de ef be ad de 43 10 ef be ad de ef be ad de ef be ad de ef be ad de Fixes: af39533 ("Bluetooth: btintel: Add Intel devcoredump support") Signed-off-by: Kiran K <[email protected]> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
1 parent 7967dc8 commit d5359a7

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/bluetooth/btintel.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3288,13 +3288,12 @@ static int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb)
32883288
case INTEL_TLV_TEST_EXCEPTION:
32893289
/* Generate devcoredump from exception */
32903290
if (!hci_devcd_init(hdev, skb->len)) {
3291-
hci_devcd_append(hdev, skb);
3291+
hci_devcd_append(hdev, skb_clone(skb, GFP_ATOMIC));
32923292
hci_devcd_complete(hdev);
32933293
} else {
32943294
bt_dev_err(hdev, "Failed to generate devcoredump");
3295-
kfree_skb(skb);
32963295
}
3297-
return 0;
3296+
break;
32983297
default:
32993298
bt_dev_err(hdev, "Invalid exception type %02X", tlv->val[0]);
33003299
}

0 commit comments

Comments
 (0)