Skip to content

Commit d897b68

Browse files
committed
Merge tag 'kbuild-fixes-v5.18' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
Pull Kbuild fixes from Masahiro Yamada: - Fix empty $(PYTHON) expansion. - Fix UML, which got broken by the attempt to suppress Clang warnings. - Fix warning message in modpost. * tag 'kbuild-fixes-v5.18' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: modpost: restore the warning message for missing symbol versions Revert "um: clang: Strip out -mno-global-merge from USER_CFLAGS" kbuild: Remove '-mno-global-merge' kbuild: fix empty ${PYTHON} in scripts/link-vmlinux.sh kconfig: remove stale comment about removed kconfig_print_symbol()
2 parents 0b0fa57 + bf5c0c2 commit d897b68

File tree

5 files changed

+2
-17
lines changed

5 files changed

+2
-17
lines changed

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -793,10 +793,6 @@ ifdef CONFIG_CC_IS_CLANG
793793
KBUILD_CPPFLAGS += -Qunused-arguments
794794
# The kernel builds with '-std=gnu11' so use of GNU extensions is acceptable.
795795
KBUILD_CFLAGS += -Wno-gnu
796-
# CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
797-
# source of a reference will be _MergedGlobals and not on of the whitelisted names.
798-
# See modpost pattern 2
799-
KBUILD_CFLAGS += -mno-global-merge
800796
else
801797

802798
# gcc inanely warns about local variables called 'main'

arch/um/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ USER_CFLAGS = $(patsubst $(KERNEL_DEFINES),,$(patsubst -I%,,$(KBUILD_CFLAGS))) \
7575
-D_FILE_OFFSET_BITS=64 -idirafter $(srctree)/include \
7676
-idirafter $(objtree)/include -D__KERNEL__ -D__UM_HOST__
7777

78-
ifdef CONFIG_CC_IS_CLANG
79-
USER_CFLAGS := $(patsubst -mno-global-merge,,$(USER_CFLAGS))
80-
endif
81-
8278
#This will adjust *FLAGS accordingly to the platform.
8379
include $(srctree)/$(ARCH_DIR)/Makefile-os-$(OS)
8480

scripts/kconfig/confdata.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -658,13 +658,6 @@ static char *escape_string_value(const char *in)
658658
return out;
659659
}
660660

661-
/*
662-
* Kconfig configuration printer
663-
*
664-
* This printer is used when generating the resulting configuration after
665-
* kconfig invocation and `defconfig' files. Unset symbol might be omitted by
666-
* passing a non-NULL argument to the printer.
667-
*/
668661
enum output_n { OUTPUT_N, OUTPUT_N_AS_UNSET, OUTPUT_N_NONE };
669662

670663
static void __print_symbol(FILE *fp, struct symbol *sym, enum output_n output_n,

scripts/link-vmlinux.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ gen_initcalls()
5050
{
5151
info GEN .tmp_initcalls.lds
5252

53-
${PYTHON} ${srctree}/scripts/jobserver-exec \
53+
${PYTHON3} ${srctree}/scripts/jobserver-exec \
5454
${PERL} ${srctree}/scripts/generate_initcall_order.pl \
5555
${KBUILD_VMLINUX_OBJS} ${KBUILD_VMLINUX_LIBS} \
5656
> .tmp_initcalls.lds

scripts/mod/modpost.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod,
674674
unsigned int crc;
675675

676676
if (sym->st_shndx == SHN_UNDEF) {
677-
warn("EXPORT symbol \"%s\" [%s%s] version ...\n"
677+
warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
678678
"Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
679679
symname, mod->name, mod->is_vmlinux ? "" : ".ko",
680680
symname);

0 commit comments

Comments
 (0)