Skip to content

Commit ded3021

Browse files
diandersJiri Kosina
authored andcommitted
dt-bindings: HID: i2c-hid: elan: Introduce bindings for Elan eKTH6915
Like many i2c-hid touchscreen controllers, the Elan eKTH6915 controller has a reset gpio. For the Goodix GT7375P touchscreen the decision was to add a new binding rather than trying to add a new GPIO to the existing i2c-hid binding. We'll follow the lead and do it here, too. SIDE NOTE: the Elan eKTH6915 is a touchscreen _controller_ that's included as a part on some touchscreens. The reset line isn't truly necessary for the functioning of the touchscreen, so it's possible that some designs won't have it hooked up and will just guarantee the power sequencing requirements with RLC circuits. Thus, we'll mark the reset gpio as optional. Note that if the reset GPIO isn't used there's actually no true need to use the "elan,ekth6915" compatible instead of the "hid-over-i2c" on Linux. However: - Officially using just "hid-over-i2c" for this device violates the existing "hid-over-i2c" bindings. The bindings say that you're not supposed to use "post-power-on-delay-ms" without specifying a more specific compatible. Currently the Linux driver doesn't enforce this, but it violates the bindings to just use "hid-over-i2c". ...and if you're going to add a more specific compatible anyway, might as well do it right. - Using this compatible means we don't need to specify "hid-descr-addr" since it's inferred from the compatible. - Using this compatible means that the regulator names match the names on the Elan datasheet (vcc33 / vccio) vs the generic hid-over-i2c (vdd / vddl). Signed-off-by: Douglas Anderson <[email protected]> Reviewed-by: Dmitry Torokhov <[email protected]> Reviewed-by: Rob Herring <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent aa051d3 commit ded3021

File tree

1 file changed

+65
-0
lines changed

1 file changed

+65
-0
lines changed
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
2+
%YAML 1.2
3+
---
4+
$id: http://devicetree.org/schemas/input/elan,ekth6915.yaml#
5+
$schema: http://devicetree.org/meta-schemas/core.yaml#
6+
7+
title: Elan eKTH6915 touchscreen controller
8+
9+
maintainers:
10+
- Douglas Anderson <[email protected]>
11+
12+
description:
13+
Supports the Elan eKTH6915 touchscreen controller.
14+
This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
15+
16+
properties:
17+
compatible:
18+
items:
19+
- const: elan,ekth6915
20+
21+
reg:
22+
const: 0x10
23+
24+
interrupts:
25+
maxItems: 1
26+
27+
reset-gpios:
28+
description: Reset GPIO; not all touchscreens using eKTH6915 hook this up.
29+
30+
vcc33-supply:
31+
description: The 3.3V supply to the touchscreen.
32+
33+
vccio-supply:
34+
description:
35+
The IO supply to the touchscreen. Need not be specified if this is the
36+
same as the 3.3V supply.
37+
38+
required:
39+
- compatible
40+
- reg
41+
- interrupts
42+
- vcc33-supply
43+
44+
additionalProperties: false
45+
46+
examples:
47+
- |
48+
#include <dt-bindings/gpio/gpio.h>
49+
#include <dt-bindings/interrupt-controller/irq.h>
50+
51+
i2c {
52+
#address-cells = <1>;
53+
#size-cells = <0>;
54+
55+
ap_ts: touchscreen@10 {
56+
compatible = "elan,ekth6915";
57+
reg = <0x10>;
58+
59+
interrupt-parent = <&tlmm>;
60+
interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
61+
62+
reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
63+
vcc33-supply = <&pp3300_ts>;
64+
};
65+
};

0 commit comments

Comments
 (0)