Skip to content

Commit e930bea

Browse files
gennartanbroonie
authored andcommitted
ASoC: tlv320adc3xxx: BUG: Correct micbias setting
The micbias setting for tlv320adc can also have the value '3' which means that the micbias ouput pin is connected to the input pin AVDD. Signed-off-by: Antoine Gennart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 892fbdb commit e930bea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/soc/codecs/tlv320adc3xxx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293
#define ADC3XXX_BYPASS_RPGA 0x80
294294

295295
/* MICBIAS control bits */
296-
#define ADC3XXX_MICBIAS_MASK 0x2
296+
#define ADC3XXX_MICBIAS_MASK 0x3
297297
#define ADC3XXX_MICBIAS1_SHIFT 5
298298
#define ADC3XXX_MICBIAS2_SHIFT 3
299299

@@ -1099,7 +1099,7 @@ static int adc3xxx_parse_dt_micbias(struct adc3xxx *adc3xxx,
10991099
unsigned int val;
11001100

11011101
if (!of_property_read_u32(np, propname, &val)) {
1102-
if (val >= ADC3XXX_MICBIAS_AVDD) {
1102+
if (val > ADC3XXX_MICBIAS_AVDD) {
11031103
dev_err(dev, "Invalid property value for '%s'\n", propname);
11041104
return -EINVAL;
11051105
}

0 commit comments

Comments
 (0)