Skip to content

Commit f956052

Browse files
name2965gregkh
authored andcommitted
vt: prevent kernel-infoleak in con_font_get()
font.data may not initialize all memory spaces depending on the implementation of vc->vc_sw->con_font_get. This may cause info-leak, so to prevent this, it is safest to modify it to initialize the allocated memory space to 0, and it generally does not affect the overall performance of the system. Cc: [email protected] Reported-by: [email protected] Fixes: 05e2600 ("VT: Bump font size limitation to 64x128 pixels") Signed-off-by: Jeongjun Park <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8cf0b93 commit f956052

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/vt/vt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4726,7 +4726,7 @@ static int con_font_get(struct vc_data *vc, struct console_font_op *op)
47264726
return -EINVAL;
47274727

47284728
if (op->data) {
4729-
font.data = kvmalloc(max_font_size, GFP_KERNEL);
4729+
font.data = kvzalloc(max_font_size, GFP_KERNEL);
47304730
if (!font.data)
47314731
return -ENOMEM;
47324732
} else

0 commit comments

Comments
 (0)