Skip to content

Commit fbdf0e2

Browse files
arndbdavem330
authored andcommitted
vmxnet3: prevent building with 64K pages
I got a warning about broken code on ARM64 with 64K pages: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow] rq->buf_info[0][i].len = PAGE_SIZE; 'len' here is a 16-bit integer, so this clearly won't work. I don't think this driver is used much on anything other than x86, so there is no need to fix this properly and we can work around it with a Kconfig dependency to forbid known-broken configurations. qemu in theory supports it on other architectures too, but presumably only for compatibility with x86 guests that also run on vmware. CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other symbols are architecture-specific names for the same thing. Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 74179d4 commit fbdf0e2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/Kconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,9 @@ config XEN_NETDEV_BACKEND
460460
config VMXNET3
461461
tristate "VMware VMXNET3 ethernet driver"
462462
depends on PCI && INET
463+
depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \
464+
IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
465+
PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES)
463466
help
464467
This driver supports VMware's vmxnet3 virtual ethernet NIC.
465468
To compile this driver as a module, choose M here: the

0 commit comments

Comments
 (0)