Skip to content

Commit fc6699d

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb: Drop unused remove function
OMAP2_VRFB is a bool, so the vrfb driver can never be compiled as a module. With that __exit_p(vrfb_remove) always evaluates to NULL and vrfb_remove() is unused. If the driver was compilable as a module, it would fail to build because the type of vrfb_remove() isn't compatible with struct platform_driver::remove(). (The former returns void, the latter int.) Fixes: aa1e49a ("OMAPDSS: VRFB: add omap_vrfb_supported()") Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 02d487f commit fc6699d

File tree

1 file changed

+1
-8
lines changed
  • drivers/video/fbdev/omap2/omapfb

1 file changed

+1
-8
lines changed

drivers/video/fbdev/omap2/omapfb/vrfb.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -368,17 +368,10 @@ static int __init vrfb_probe(struct platform_device *pdev)
368368
return 0;
369369
}
370370

371-
static void __exit vrfb_remove(struct platform_device *pdev)
372-
{
373-
vrfb_loaded = false;
374-
}
375-
376371
static struct platform_driver vrfb_driver = {
377372
.driver.name = "omapvrfb",
378-
.remove = __exit_p(vrfb_remove),
379373
};
380-
381-
module_platform_driver_probe(vrfb_driver, vrfb_probe);
374+
builtin_platform_driver_probe(vrfb_driver, vrfb_probe);
382375

383376
MODULE_AUTHOR("Tomi Valkeinen <[email protected]>");
384377
MODULE_DESCRIPTION("OMAP VRFB");

0 commit comments

Comments
 (0)