Skip to content

Commit fcad766

Browse files
dingtianhongdavem330
authored andcommitted
mwifiex: slight optimization of addr compare
Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Bing Zhao <[email protected]> Cc: John W. Linville <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Weilong Chen <[email protected]> Signed-off-by: Ding Tianhong <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 36325f3 commit fcad766

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

drivers/net/wireless/mwifiex/11n.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ mwifiex_get_ba_tbl(struct mwifiex_private *priv, int tid, u8 *ra)
483483

484484
spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
485485
list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
486-
if (!memcmp(tx_ba_tsr_tbl->ra, ra, ETH_ALEN) &&
486+
if (ether_addr_equal_unaligned(tx_ba_tsr_tbl->ra, ra) &&
487487
tx_ba_tsr_tbl->tid == tid) {
488488
spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock,
489489
flags);

drivers/net/wireless/mwifiex/sta_cmdresp.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,8 +782,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv,
782782
}
783783

784784
/* If BSSID is diff, modify current BSS parameters */
785-
if (memcmp(priv->curr_bss_params.bss_descriptor.mac_address,
786-
ibss_coal_resp->bssid, ETH_ALEN)) {
785+
if (!ether_addr_equal(priv->curr_bss_params.bss_descriptor.mac_address, ibss_coal_resp->bssid)) {
787786
/* BSSID */
788787
memcpy(priv->curr_bss_params.bss_descriptor.mac_address,
789788
ibss_coal_resp->bssid, ETH_ALEN);

drivers/net/wireless/mwifiex/sta_rx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ int mwifiex_process_sta_rx_packet(struct mwifiex_private *priv,
224224
* directly to os. Don't pass thru rx reordering
225225
*/
226226
if (!IS_11N_ENABLED(priv) ||
227-
memcmp(priv->curr_addr, rx_pkt_hdr->eth803_hdr.h_dest, ETH_ALEN)) {
227+
!ether_addr_equal_unaligned(priv->curr_addr, rx_pkt_hdr->eth803_hdr.h_dest)) {
228228
mwifiex_process_rx_packet(priv, skb);
229229
return ret;
230230
}

0 commit comments

Comments
 (0)