Skip to content

Commit fcafdde

Browse files
lenbIngo Molnar
authored andcommitted
x86/smpboot: Fix CPU #1 boot timeout
The following commit: a9bcaa0 ("x86/smpboot: Remove SIPI delays from cpu_up()") Caused some Intel Core2 processors to time-out when bringing up CPU #1, resulting in the missing of that CPU after bootup. That patch reduced the SIPI delays from udelay() 300, 200 to udelay() 0, 0 on modern processors. Several Intel(R) Core(TM)2 systems failed to bring up CPU #1 10/10 times after that change. Increasing either of the SIPI delays to udelay(1) results in success. So here we increase both to udelay(10). While this may be 20x slower than the absolute minimum, it is still 20x to 30x faster than the original code. Tested-by: Donald Parsons <[email protected]> Tested-by: Shane <[email protected]> Signed-off-by: Len Brown <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: [email protected] Cc: [email protected] Link: http://lkml.kernel.org/r/6dd554ee8945984d85aafb2ad35793174d068af0.1444968087.git.len.brown@intel.com Signed-off-by: Ingo Molnar <[email protected]>
1 parent f1ccd24 commit fcafdde

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

arch/x86/kernel/smpboot.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,9 @@ wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
660660
/*
661661
* Give the other CPU some time to accept the IPI.
662662
*/
663-
if (init_udelay)
663+
if (init_udelay == 0)
664+
udelay(10);
665+
else
664666
udelay(300);
665667

666668
pr_debug("Startup point 1\n");
@@ -671,7 +673,9 @@ wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
671673
/*
672674
* Give the other CPU some time to accept the IPI.
673675
*/
674-
if (init_udelay)
676+
if (init_udelay == 0)
677+
udelay(10);
678+
else
675679
udelay(200);
676680

677681
if (maxlvt > 3) /* Due to the Pentium erratum 3AP. */

0 commit comments

Comments
 (0)