Skip to content

Commit ffecba8

Browse files
tititiou36Christoph Hellwig
authored andcommitted
agp/intel: Remove usage of the deprecated "pci-dma-compat.h" API
In [1], Christoph Hellwig has proposed to remove the wrappers in include/linux/pci-dma-compat.h. Some reasons why this API should be removed have been given by Julia Lawall in [2]. A coccinelle script has been used to perform the needed transformation. It can be found in [3]. [1]: https://lore.kernel.org/kernel-janitors/[email protected]/ [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ [3]: https://lore.kernel.org/kernel-janitors/[email protected]/ Signed-off-by: Christophe JAILLET <[email protected]> Reviewed-by: Arnd Bergmann <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent 06cc5cf commit ffecba8

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

drivers/char/agp/intel-gtt.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ static int intel_gtt_map_memory(struct page **pages,
111111
for_each_sg(st->sgl, sg, num_entries, i)
112112
sg_set_page(sg, pages[i], PAGE_SIZE, 0);
113113

114-
if (!pci_map_sg(intel_private.pcidev,
115-
st->sgl, st->nents, PCI_DMA_BIDIRECTIONAL))
114+
if (!dma_map_sg(&intel_private.pcidev->dev, st->sgl, st->nents,
115+
DMA_BIDIRECTIONAL))
116116
goto err;
117117

118118
return 0;
@@ -127,8 +127,8 @@ static void intel_gtt_unmap_memory(struct scatterlist *sg_list, int num_sg)
127127
struct sg_table st;
128128
DBG("try unmapping %lu pages\n", (unsigned long)mem->page_count);
129129

130-
pci_unmap_sg(intel_private.pcidev, sg_list,
131-
num_sg, PCI_DMA_BIDIRECTIONAL);
130+
dma_unmap_sg(&intel_private.pcidev->dev, sg_list, num_sg,
131+
DMA_BIDIRECTIONAL);
132132

133133
st.sgl = sg_list;
134134
st.orig_nents = st.nents = num_sg;
@@ -303,9 +303,9 @@ static int intel_gtt_setup_scratch_page(void)
303303
set_pages_uc(page, 1);
304304

305305
if (intel_private.needs_dmar) {
306-
dma_addr = pci_map_page(intel_private.pcidev, page, 0,
307-
PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);
308-
if (pci_dma_mapping_error(intel_private.pcidev, dma_addr)) {
306+
dma_addr = dma_map_page(&intel_private.pcidev->dev, page, 0,
307+
PAGE_SIZE, DMA_BIDIRECTIONAL);
308+
if (dma_mapping_error(&intel_private.pcidev->dev, dma_addr)) {
309309
__free_page(page);
310310
return -EINVAL;
311311
}
@@ -552,9 +552,9 @@ static void intel_gtt_teardown_scratch_page(void)
552552
{
553553
set_pages_wb(intel_private.scratch_page, 1);
554554
if (intel_private.needs_dmar)
555-
pci_unmap_page(intel_private.pcidev,
556-
intel_private.scratch_page_dma,
557-
PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);
555+
dma_unmap_page(&intel_private.pcidev->dev,
556+
intel_private.scratch_page_dma, PAGE_SIZE,
557+
DMA_BIDIRECTIONAL);
558558
__free_page(intel_private.scratch_page);
559559
}
560560

@@ -1412,13 +1412,13 @@ int intel_gmch_probe(struct pci_dev *bridge_pdev, struct pci_dev *gpu_pdev,
14121412

14131413
if (bridge) {
14141414
mask = intel_private.driver->dma_mask_size;
1415-
if (pci_set_dma_mask(intel_private.pcidev, DMA_BIT_MASK(mask)))
1415+
if (dma_set_mask(&intel_private.pcidev->dev, DMA_BIT_MASK(mask)))
14161416
dev_err(&intel_private.pcidev->dev,
14171417
"set gfx device dma mask %d-bit failed!\n",
14181418
mask);
14191419
else
1420-
pci_set_consistent_dma_mask(intel_private.pcidev,
1421-
DMA_BIT_MASK(mask));
1420+
dma_set_coherent_mask(&intel_private.pcidev->dev,
1421+
DMA_BIT_MASK(mask));
14221422
}
14231423

14241424
if (intel_gtt_init() != 0) {

0 commit comments

Comments
 (0)