rust: module.rs: Replace unwrap() with expect() #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylfrena
force-pushed
the
lin-fix-unwrap
branch
from
5580453 to
6c960e8
Compare
Sylfrena
force-pushed
the
lin-fix-unwrap
branch
from
6c960e8 to
77b3155
Compare
ojeda
requested changes
Mar 29, 2021
rust/module.rs
Outdated
| @@ -673,5 +677,5 @@ pub fn module(ts: TokenStream) -> TokenStream { | |||
| params_modinfo = params_modinfo, | |||
| generated_array_types = generated_array_types, | |||
| initcall_section = ".initcall6.init" | |||
| ).parse().unwrap() | |||
| ).parse().expect("LexError returned whle trying to parse the string token stream.") | |||
There was a problem hiding this comment.
Typo:
Suggested change
| ).parse().expect("LexError returned whle trying to parse the string token stream.") | |
| ).parse().expect("LexError returned while trying to parse the string token stream") |
Also, perhaps we can just say:
Error parsing formatted string into token stream
Use expect() instead of unwrap() to add more details about the error in case of a panic. Fixes torvalds#90. Signed-off-by: Sumera Priyadarsini <[email protected]>
Signed-off-by: Sumera Priyadarsini <[email protected]>
ojeda
approved these changes
Apr 5, 2021
|
Thanks a lot! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use expect() instead of unwrap() to add more details
about the error in case of a panic.
Fixes #90.
Signed-off-by: Sumera Priyadarsini [email protected]