Skip to content

CI: add ccache #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2021
Merged

CI: add ccache #277

merged 1 commit into from
May 19, 2021

Conversation

obviyus
Copy link

@obviyus obviyus commented May 19, 2021

Fixes #262

Some notes:

  • env.MATRIX_NAME holds the unique run parameters for each matrix combination
  • The cache gets updated after every run for each unique matrix combination
  • On average, runs with ccache are ~6-8 minutes faster

Results of a run with ccache can be found here: https://github.com/obviyus/linux/actions/runs/856000320

cc: @alex

@obviyus
CI: add ccache
090f9e2 
Added ccache to retrieve build artifcats from previous runs to avoid
recompiling and speed up builds.

Signed-off-by: Ayaan Zaidi <[email protected]>
@bjorn3
Copy link
Member

bjorn3 commented May 19, 2021

Using sccache instead may be a good idea. Sccache also supports rust unlike ccache. It may not support all rustc arguments required by rust-for-linux though. You can install it using cargo install sccache though it is suggested to use a pre-compiled version on CI like can be found at https://github.com/mozilla/sccache/releases. You then need to prefix all compiler commands with sccache. Eg sccache gcc ... or sccache rustc .... Finally you can upload ~/.cache/sccache as cache. You can use sccache --show-stats for stats.

@ksquirrel
Copy link
Member

Review of 090f9e20527a:

  • ✔️ Commit 090f9e2: Looks fine!

@obviyus obviyus marked this pull request as ready for review May 19, 2021 11:57
alex
alex approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we can iterate this, e.g. by introducing sccache, but for now this seems to work, so let's get the benefits!

@alex alex merged commit 3729708 into Rust-for-Linux:rust May 19, 2021
ojeda pushed a commit that referenced this pull request Sep 12, 2023
@ummakynes
netfilter: nf_tables: Unbreak audit log reset
9b5ba5c 
Deliver audit log from __nf_tables_dump_rules(), table dereference at
the end of the table list loop might point to the list head, leading to
this crash.

[ 4137.407349] BUG: unable to handle page fault for address: 00000000001f3c50
[ 4137.407357] #PF: supervisor read access in kernel mode
[ 4137.407359] #PF: error_code(0x0000) - not-present page
[ 4137.407360] PGD 0 P4D 0
[ 4137.407363] Oops: 0000 [#1] PREEMPT SMP PTI
[ 4137.407365] CPU: 4 PID: 500177 Comm: nft Not tainted 6.5.0+ #277
[ 4137.407369] RIP: 0010:string+0x49/0xd0
[ 4137.407374] Code: ff 77 36 45 89 d1 31 f6 49 01 f9 66 45 85 d2 75 19 eb 1e 49 39 f8 76 02 88 07 48 83 c7 01 83 c6 01 48 83 c2 01 4c 39 cf 74 07 <0f> b6 02 84 c0 75 e2 4c 89 c2 e9 58 e5 ff ff 48 c7 c0 0e b2 ff 81
[ 4137.407377] RSP: 0018:ffff8881179737f0 EFLAGS: 00010286
[ 4137.407379] RAX: 00000000001f2c50 RBX: ffff888117973848 RCX: ffff0a00ffffff04
[ 4137.407380] RDX: 00000000001f3c50 RSI: 0000000000000000 RDI: 0000000000000000
[ 4137.407381] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000ffffffff
[ 4137.407383] R10: ffffffffffffffff R11: ffff88813584d200 R12: 0000000000000000
[ 4137.407384] R13: ffffffffa15cf709 R14: 0000000000000000 R15: ffffffffa15cf709
[ 4137.407385] FS:  00007fcfc18bb580(0000) GS:ffff88840e700000(0000) knlGS:0000000000000000
[ 4137.407387] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 4137.407388] CR2: 00000000001f3c50 CR3: 00000001055b2001 CR4: 00000000001706e0
[ 4137.407390] Call Trace:
[ 4137.407392]  <TASK>
[ 4137.407393]  ? __die+0x1b/0x60
[ 4137.407397]  ? page_fault_oops+0x6b/0xa0
[ 4137.407399]  ? exc_page_fault+0x60/0x120
[ 4137.407403]  ? asm_exc_page_fault+0x22/0x30
[ 4137.407408]  ? string+0x49/0xd0
[ 4137.407410]  vsnprintf+0x257/0x4f0
[ 4137.407414]  kvasprintf+0x3e/0xb0
[ 4137.407417]  kasprintf+0x3e/0x50
[ 4137.407419]  nf_tables_dump_rules+0x1c0/0x360 [nf_tables]
[ 4137.407439]  ? __alloc_skb+0xc3/0x170
[ 4137.407442]  netlink_dump+0x170/0x330
[ 4137.407447]  __netlink_dump_start+0x227/0x300
[ 4137.407449]  nf_tables_getrule+0x205/0x390 [nf_tables]

Deliver audit log only once at the end of the rule dump+reset for
consistency with the set dump+reset.

Ensure audit reset access to table under rcu read side lock. The table
list iteration holds rcu read lock side, but recent audit code
dereferences table object out of the rcu read lock side.

Fixes: ea078ae ("netfilter: nf_tables: Audit log rule reset")
Fixes: 7e9be11 ("netfilter: nf_tables: Audit log setelem reset")
Signed-off-by: Pablo Neira Ayuso <[email protected]>
Acked-by: Phil Sutter <[email protected]>
Signed-off-by: Florian Westphal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up CI with ccache
4 participants
@obviyus @bjorn3 @ksquirrel @alex