rust: fix bug where unsafe expressions didn't require unsafe block. #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `init_with_lockdep` macro, the macros were evaluated inside an unsafe block, so they could contain unsafe operations without requiring an explicit unsafe block on the call site. Fixed by evaluating `$obj` and `$name` outside an unsafe block. Reported-by: Sven Van Asbroeck <[email protected]> Signed-off-by: Wedson Almeida Filho <[email protected]>
|
Review of
|
This was referenced Jun 26, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
init_with_lockdepmacro, the macros were evaluated inside anunsafe block, so they could contain unsafe operations without requiring
an explicit unsafe block on the call site.
Fixed by evaluating
$objand$nameoutside an unsafe block.Reported-by: Sven Van Asbroeck [email protected]
Signed-off-by: Wedson Almeida Filho [email protected]