rust: gpio: add support for registering irq chips with gpio chip. #565
Conversation
|
|
||
| // SAFETY: Registration with and unregistration from the gpio subsystem (including irq chips for | ||
| // them) can happen from any thread. Additionally, `T::Data` (which is dropped during | ||
| // unregistration) is `Send`, so it is ok to move `Registration` to different threads. |
There was a problem hiding this comment.
(Off-topic: I wonder if it would be useful in cases like this to assert safety conditions like T::Data is Send nearby where we rely on them too, specially in cases where it may be too far away etc.)
There was a problem hiding this comment.
I like the idea of having the machine check some of our stated assumptions. I added a bound for this particular, though it is just repeating one that already exists.
It will help catch problems if in the future someone inadvertently removes the bounds from T::Data. On the other hand, we were asking the Rust folks to help us avoid repeating such bounds :)
There was a problem hiding this comment.
It will help catch problems if in the future someone inadvertently removes the bounds from
T::Data
Exactly -- I was thinking about the "SAFETY 'proofs' in both ends" discussion and while for "comments" it would likely be too annoying, for something that can be machine checked (& that can be asserted on this side), it seems worth to do.
This is used by the PL061 driver. Signed-off-by: Wedson Almeida Filho <[email protected]>
This is used by the PL061 driver.
Signed-off-by: Wedson Almeida Filho [email protected]