Skip to content

Commit 0ceec67

Browse files
authored
refactor(Charts - New): rename xIndex to dataIndex in onDataPointClick event (#479)
1 parent a935336 commit 0ceec67

File tree

8 files changed

+11
-10
lines changed

8 files changed

+11
-10
lines changed

packages/charts/src/components/BarChart/BarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ const BarChart: FC<BarChartProps> = forwardRef((props: BarChartProps, ref: Ref<a
154154
.find((key) => payload[key] === value),
155155
value,
156156
payload: payload.payload,
157-
xIndex: i
157+
dataIndex: i
158158
})
159159
);
160160
}

packages/charts/src/components/ColumnChart/ColumnChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ const ColumnChart: FC<ColumnChartProps> = forwardRef((props: ColumnChartProps, r
155155
: payload[key] === payload.value && key !== 'value'
156156
)[0],
157157
value: payload.value.length ? payload.value[1] - payload.value[0] : payload.value,
158-
xIndex: eventOrIndex,
158+
dataIndex: eventOrIndex,
159159
payload: payload.payload
160160
})
161161
);

packages/charts/src/components/ComposedChart/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
173173
onDataPointClick(
174174
enrichEventWithDetails(event ?? eventOrIndex, {
175175
value: payload.value.length ? payload.value[1] - payload.value[0] : payload.value,
176-
xIndex: payload.index ?? eventOrIndex,
176+
dataIndex: payload.index ?? eventOrIndex,
177177
dataKey: payload.value.length
178178
? Object.keys(payload).filter((key) =>
179179
payload.value.length
@@ -192,7 +192,7 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
192192
{
193193
value: eventOrIndex.value,
194194
dataKey: eventOrIndex.dataKey,
195-
xIndex: eventOrIndex.index,
195+
dataIndex: eventOrIndex.index,
196196
payload: eventOrIndex.payload
197197
}
198198
)

packages/charts/src/components/LineChart/LineChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ const LineChart: FC<LineChartProps> = forwardRef((props: LineChartProps, ref: Re
145145
{
146146
value: eventOrIndex.value,
147147
dataKey: eventOrIndex.dataKey,
148-
xIndex: eventOrIndex.index,
148+
dataIndex: eventOrIndex.index,
149149
payload: eventOrIndex.payload
150150
}
151151
)

packages/charts/src/components/MicroBarChart/MicroBarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ const MicroBarChart: FC<MicroBarChartProps> = forwardRef((props: MicroBarChartPr
107107
)[0],
108108
value: e.value.length ? e.value[1] - e.value[0] : e.value,
109109
payload: e.payload,
110-
xIndex: i
110+
dataIndex: i
111111
})
112112
);
113113
}

packages/charts/src/components/PieChart/PieChart.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ const PieChart: FC<PieChartProps> = forwardRef((props: PieChartProps, ref: Ref<a
103103
value: payload.value,
104104
dataKey: measure.accessor,
105105
name: payload.name,
106-
payload: payload.payload
106+
payload: payload.payload,
107+
dataIndex: index
107108
})
108109
);
109110
}

packages/charts/src/components/RadarChart/RadarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ const RadarChart: FC<RadarChartProps> = forwardRef((props: RadarChartProps, ref:
114114
value: eventOrIndex.value,
115115
dataKey: eventOrIndex.dataKey,
116116
name: eventOrIndex.payload.label,
117-
xIndex: eventOrIndex.index,
117+
dataIndex: eventOrIndex.index,
118118
payload: eventOrIndex.payload
119119
}
120120
)

packages/charts/src/components/RadialChart/RadialChart.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export interface RadialChartProps extends CommonProps {
1111
maxValue?: number;
1212
displayValue?: number | string;
1313
color?: CSSProperties['color'];
14-
onDataPointClick?: (event: CustomEvent<{ value: unknown; payload: unknown; xIndex: number }>) => void;
14+
onDataPointClick?: (event: CustomEvent<{ value: unknown; payload: unknown; dataIndex: number }>) => void;
1515
}
1616

1717
/**
@@ -34,7 +34,7 @@ const RadialChart: FC<RadialChartProps> = forwardRef((props: RadialChartProps, r
3434
enrichEventWithDetails(event, {
3535
value: payload.value,
3636
payload: payload.payload,
37-
xIndex: i
37+
dataIndex: i
3838
})
3939
);
4040
}

0 commit comments

Comments
 (0)