Skip to content

Commit 10eda2c

Browse files
authored
fix(AnalyticalTable): center align indicator icons of columns (#4572)
1 parent 29996f3 commit 10eda2c

File tree

1 file changed

+4
-10
lines changed
  • packages/main/src/components/AnalyticalTable/ColumnHeader

1 file changed

+4
-10
lines changed

packages/main/src/components/AnalyticalTable/ColumnHeader/index.tsx

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,10 @@ const styles = {
8282
textAlign: 'start'
8383
},
8484
iconContainer: {
85-
display: 'inline-block',
85+
display: 'flex',
8686
position: 'absolute',
87-
color: ThemingParameters.sapContent_IconColor
87+
color: ThemingParameters.sapContent_IconColor,
88+
insetInlineEnd: '0.5rem'
8889
},
8990
selectAllCheckBoxContainer: {
9091
display: 'flex',
@@ -158,11 +159,7 @@ export const ColumnHeader: FC<ColumnHeaderProps> = (props: ColumnHeaderProps) =>
158159

159160
if (margin > 0) margin += 0.5;
160161

161-
if (isRtl) {
162-
style.marginLeft = `${margin}rem`;
163-
} else {
164-
style.marginRight = `${margin}rem`;
165-
}
162+
style.marginInlineEnd = `${margin}rem`;
166163

167164
return style;
168165
})();
@@ -180,8 +177,6 @@ export const ColumnHeader: FC<ColumnHeaderProps> = (props: ColumnHeaderProps) =>
180177
? { right: 0, transform: `translateX(-${virtualColumn.start}px)` }
181178
: { left: 0, transform: `translateX(${virtualColumn.start}px)` };
182179

183-
const iconContainerDirectionStyles = isRtl ? { left: '0.5rem' } : { right: '0.5rem' };
184-
185180
const handleHeaderCellKeyDown = (e) => {
186181
onKeyDown?.(e);
187182
if (hasPopover && e.code === 'Enter') {
@@ -261,7 +256,6 @@ export const ColumnHeader: FC<ColumnHeaderProps> = (props: ColumnHeaderProps) =>
261256
</Text>
262257
<div
263258
className={classes.iconContainer}
264-
style={iconContainerDirectionStyles}
265259
data-component-name={`AnalyticalTableHeaderIconsContainer-${columnId}`}
266260
>
267261
{isFiltered && <Icon name={iconFilter} aria-hidden />}

0 commit comments

Comments
 (0)