use correct instance property for useVisibleColumnsWidth hook + cleanup

Author: Lukas742

packages/main/src/components/AnalyticalTable/AnayticalTable.jss.ts

@@ -6,9 +6,7 @@ const styles = {
     position: 'relative',
     width: '100%',
     maxWidth: '100%',
-    //todo hidden was default
-    // overflowY: 'hidden',
-    overflowY: 'auto',
+    overflowY: 'hidden',
     overflowX: 'auto',
     height: '100%',
     minHeight: '3rem',

packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeaderContainer.tsx

@@ -1,4 +1,4 @@
-import { ThemingParameters } from '@ui5/webcomponents-react-base';
+import { ThemingParameters } from '@ui5/webcomponents-react-base/lib/ThemingParameters';
 import React, { useCallback } from 'react';
 import { createUseStyles } from 'react-jss';
 import { useVirtual } from 'react-virtual';
@@ -36,7 +36,6 @@ export const ColumnHeaderContainer = (props) => {
     onDragEnter,
     onDragEnd,
     dragOver,
-
     tableRef,
     visibleColumnsWidth,
     overscanCountHorizontal,

packages/main/src/components/AnalyticalTable/ColumnHeader/index.tsx

@@ -41,9 +41,7 @@ export interface ColumnHeaderProps {
   isDraggable: boolean;
   role: string;
   isLastColumn: boolean;
-
-  //todo
-  virtualColumn: any;
+  virtualColumn: ColumnType;
 }
 
 const styles = {
@@ -106,7 +104,6 @@ export const ColumnHeader: FC<ColumnHeaderProps> = (props: ColumnHeaderProps) =>
     isDraggable,
     dragOver,
     role,
-
     virtualColumn
   } = props;
 

packages/main/src/components/AnalyticalTable/virtualization/VirtualTableBody.tsx renamed to packages/main/src/components/AnalyticalTable/TableBody/VirtualTableBody.tsx

@@ -1,6 +1,6 @@
 import '@ui5/webcomponents-icons/dist/icons/navigation-down-arrow';
 import '@ui5/webcomponents-icons/dist/icons/navigation-right-arrow';
-import { useConsolidatedRef } from '@ui5/webcomponents-react-base';
+import { useConsolidatedRef } from '@ui5/webcomponents-react-base/lib/useConsolidatedRef';
 import React, { MutableRefObject, useCallback, useRef } from 'react';
 import { useVirtual } from 'react-virtual';
 

packages/main/src/components/AnalyticalTable/VirtualTableBodyContainer.tsx renamed to packages/main/src/components/AnalyticalTable/TableBody/VirtualTableBodyContainer.tsx

@@ -1,4 +1,4 @@
-import { StyleClassHelper } from '@ui5/webcomponents-react-base';
+import { StyleClassHelper } from '@ui5/webcomponents-react-base/lib/StyleClassHelper';
 import React, { useCallback, useEffect, useRef, useState } from 'react';
 import { GlobalStyleClasses } from '@ui5/webcomponents-react/lib/GlobalStyleClasses';
 
@@ -12,7 +12,6 @@ export const VirtualTableBodyContainer = (props) => {
     infiniteScroll,
     infiniteScrollThreshold,
     onLoadMore,
-    selectionMode,
     rows,
     internalRowHeight
   } = props;
@@ -29,7 +28,6 @@ export const VirtualTableBodyContainer = (props) => {
   const lastScrollTop = useRef(0);
   const firedInfiniteLoadEvents = useRef(new Set());
 
-  //todo test
   const onScroll = useCallback(
     (event) => {
       const scrollOffset = event.target.scrollTop;
@@ -61,20 +59,18 @@ export const VirtualTableBodyContainer = (props) => {
   );
 
   return (
-    <>
-      <div
-        className={classNames}
-        ref={parentRef}
-        onScroll={onScroll}
-        style={{
-          position: 'relative',
-          overflowY: 'auto',
-          height: `${tableBodyHeight}px`,
-          width: `${totalColumnsWidth}px`
-        }}
-      >
-        {isMounted && children}
-      </div>
-    </>
+    <div
+      className={classNames}
+      ref={parentRef}
+      onScroll={onScroll}
+      style={{
+        position: 'relative',
+        overflowY: 'auto',
+        height: `${tableBodyHeight}px`,
+        width: `${totalColumnsWidth}px`
+      }}
+    >
+      {isMounted && children}
+    </div>
   );
 };