Skip to content

Commit 2239a49

Browse files
authored
fix(ComposedChart): invoke onDataPointClick only on the points of the area chart (#3687)
1 parent 657fcf8 commit 2239a49

File tree

1 file changed

+5
-3
lines changed
  • packages/charts/src/components/ComposedChart

1 file changed

+5
-3
lines changed

packages/charts/src/components/ComposedChart/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,15 +210,15 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
210210
onDataPointClick(
211211
enrichEventWithDetails(event ?? eventOrIndex, {
212212
value: payloadValueLength ? payload.value[1] - payload.value[0] : payload.value,
213-
dataIndex: payload.index ?? eventOrIndex,
213+
dataIndex: payload.index ?? typeof eventOrIndex === 'number' ? eventOrIndex : undefined,
214214
dataKey: payloadValueLength
215215
? Object.keys(payload).filter((key) =>
216216
payload.value.length
217217
? payload[key] === payload.value[1] - payload.value[0]
218218
: payload[key] === payload.value && key !== 'value'
219219
)[0]
220220
: payload.dataKey ??
221-
Object.keys(payload).find((key) => payload[key] === payload.value && key !== 'value'),
221+
Object.keys(payload).find((key) => payload[key] && payload[key] === payload.value && key !== 'value'),
222222
payload: payload.payload
223223
})
224224
);
@@ -465,8 +465,10 @@ const ComposedChart: FC<ComposedChartProps> = forwardRef((props: ComposedChartPr
465465
chartElementProps.dot = !isBigDataSet;
466466
chartElementProps.fillOpacity = 0.3;
467467
chartElementProps.strokeOpacity = element.opacity;
468-
chartElementProps.onClick = onDataPointClickInternal;
469468
chartElementProps.strokeWidth = element.width;
469+
chartElementProps.activeDot = {
470+
onClick: onDataPointClickInternal
471+
};
470472
break;
471473
}
472474

0 commit comments

Comments
 (0)